base/native_library_mac.mm - Issue 2048523002: Fix base::GetNativeLibraryName() for Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/native_library_mac.mm

Issue 2048523002: Fix base::GetNativeLibraryName() for Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@native_lib_clean

Patch Set: Remove string16 version of GetNativeLibraryName Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/native_library_mac.mm

diff --git a/base/native_library_mac.mm b/base/native_library_mac.mm

index b50c6968a3ea5abfb2f905ac572be208699fb4ad..f919f69c986f521990526340084c783cafa68eed 100644

--- a/base/native_library_mac.mm

+++ b/base/native_library_mac.mm

@@ -113,8 +113,8 @@ void* GetFunctionPointerFromNativeLibrary(NativeLibrary library,

}

// static

-string16 GetNativeLibraryName(StringPiece16 name) {

- return name.as_string() + ASCIIToUTF16(".dylib");

+std::string GetNativeLibraryName(StringPiece name) {

+ return "lib" + name.as_string() + ".dylib";

}

} // namespace base

« base/native_library.h ('K') | « base/native_library_ios.mm ('k') | base/native_library_posix.cc » ('j') | no next file with comments »