Fix base::GetNativeLibraryName() for Mac.

base/native_library.h

Index: base/native_library.h
diff --git a/base/native_library.h b/base/native_library.h
index 5dc4802c410df10def5e4407b29f5d015e6e1a00..b42b92dfa692d1e8189167eec9298dbb727c26df 100644
--- a/base/native_library.h
+++ b/base/native_library.h
@@ -11,7 +11,6 @@
 #include <string>
 
 #include "base/base_export.h"
-#include "base/strings/string16.h"
 #include "base/strings/string_piece.h"
 #include "build/build_config.h"
 
@@ -93,7 +92,7 @@ BASE_EXPORT void* GetFunctionPointerFromNativeLibrary(NativeLibrary library,
 // For example:
 // "mylib" returns "mylib.dll" on Windows, "libmylib.so" on Linux,
 // "mylib.dylib" on Mac.

[xhwang, 2016/06/07 16:24:41]

This comment needs to be updated.

[Lei Zhang, 2016/06/10 22:09:29]

Done.

-BASE_EXPORT string16 GetNativeLibraryName(StringPiece16 name);
+BASE_EXPORT std::string GetNativeLibraryName(StringPiece name);

[xhwang, 2016/06/07 16:24:41]

Don't we need to support UTF16 paths? Or since this is internal we choose not to
support it?

[Lei Zhang, 2016/06/10 22:09:29]

The callers can convert to UTF-16 if they need to. Currently it's a bit more
work because we always do conversions in GetNativeLibraryName() to make it
UTF-16, and then some callers have to convert it back.

[xhwang, 2016/06/10 23:27:26]

But the return value is std::string now, if the original path is UTF-16, how
would this work?

 
 }  // namespace base