Fix base::GetNativeLibraryName() for Mac.

base/native_library.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_NATIVE_LIBRARY_H_
 #define BASE_NATIVE_LIBRARY_H_
 
 // This file defines a cross-platform "NativeLibrary" type which represents
 // a loadable module.
 
 #include <string>
 
 #include "base/base_export.h"
-#include "base/strings/string16.h"
 #include "base/strings/string_piece.h"
 #include "build/build_config.h"
 
 #if defined(OS_WIN)
 #include <windows.h>
 #elif defined(OS_MACOSX)
 #import <CoreFoundation/CoreFoundation.h>
 #endif  // OS_*
 
 namespace base {
@@ skipping 60 matching lines @@
 // Unloads a native library.
 BASE_EXPORT void UnloadNativeLibrary(NativeLibrary library);
 
 // Gets a function pointer from a native library.
 BASE_EXPORT void* GetFunctionPointerFromNativeLibrary(NativeLibrary library,
                                                       StringPiece name);
 
 // Returns the full platform specific name for a native library.
 // For example:
 // "mylib" returns "mylib.dll" on Windows, "libmylib.so" on Linux,
 // "mylib.dylib" on Mac.

[xhwang, 2016/06/07 16:24:41]

This comment needs to be updated.

[Lei Zhang, 2016/06/10 22:09:29]

Done.

-BASE_EXPORT string16 GetNativeLibraryName(StringPiece16 name);
+BASE_EXPORT std::string GetNativeLibraryName(StringPiece name);

[xhwang, 2016/06/07 16:24:41]

Don't we need to support UTF16 paths? Or since this is internal we choose not to
support it?

[Lei Zhang, 2016/06/10 22:09:29]

The callers can convert to UTF-16 if they need to. Currently it's a bit more
work because we always do conversions in GetNativeLibraryName() to make it
UTF-16, and then some callers have to convert it back.

[xhwang, 2016/06/10 23:27:26]

But the return value is std::string now, if the original path is UTF-16, how
would this work?

 
 }  // namespace base
 
 #endif  // BASE_NATIVE_LIBRARY_H_