base/native_library_unittest.cc - Issue 2048523002: Fix base::GetNativeLibraryName() for Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/native_library_unittest.cc

Issue 2048523002: Fix base::GetNativeLibraryName() for Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@native_lib_clean

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/native_library_unittest.cc

diff --git a/base/native_library_unittest.cc b/base/native_library_unittest.cc

index 237a46fa2e7d740e3d83ead5f6475ef8e38d043b..c189f56e995c04598df5bf2d85c1a882dcafd629 100644

--- a/base/native_library_unittest.cc

+++ b/base/native_library_unittest.cc

@@ -4,7 +4,6 @@

#include "base/files/file_path.h"

#include "base/native_library.h"

-#include "base/strings/utf_string_conversions.h"

#include "testing/gtest/include/gtest/gtest.h"

namespace base {

@@ -28,14 +27,13 @@ TEST(NativeLibraryTest, GetNativeLibraryName) {

#if defined(OS_IOS)

"mylib";

#elif defined(OS_MACOSX)

- "mylib.dylib";

+ "libmylib.dylib";

#elif defined(OS_POSIX)

"libmylib.so";

#elif defined(OS_WIN)

"mylib.dll";

#endif

- EXPECT_EQ(ASCIIToUTF16(kExpectedName),

- GetNativeLibraryName(ASCIIToUTF16("mylib")));

+ EXPECT_EQ(kExpectedName, GetNativeLibraryName("mylib"));

}

} // namespace base

« no previous file with comments | « base/native_library_posix.cc ('k') | base/native_library_win.cc » ('j') | no next file with comments »