Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Side by Side Diff: base/native_library_unittest.cc

Issue 2048523002: Fix base::GetNativeLibraryName() for Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@native_lib_clean
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/native_library_posix.cc ('k') | base/native_library_win.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/files/file_path.h" 5 #include "base/files/file_path.h"
6 #include "base/native_library.h" 6 #include "base/native_library.h"
7 #include "base/strings/utf_string_conversions.h"
8 #include "testing/gtest/include/gtest/gtest.h" 7 #include "testing/gtest/include/gtest/gtest.h"
9 8
10 namespace base { 9 namespace base {
11 10
12 const FilePath::CharType kDummyLibraryPath[] = 11 const FilePath::CharType kDummyLibraryPath[] =
13 FILE_PATH_LITERAL("dummy_library"); 12 FILE_PATH_LITERAL("dummy_library");
14 13
15 TEST(NativeLibraryTest, LoadFailure) { 14 TEST(NativeLibraryTest, LoadFailure) {
16 NativeLibraryLoadError error; 15 NativeLibraryLoadError error;
17 EXPECT_FALSE(LoadNativeLibrary(FilePath(kDummyLibraryPath), &error)); 16 EXPECT_FALSE(LoadNativeLibrary(FilePath(kDummyLibraryPath), &error));
18 EXPECT_FALSE(error.ToString().empty()); 17 EXPECT_FALSE(error.ToString().empty());
19 } 18 }
20 19
21 // |error| is optional and can be null. 20 // |error| is optional and can be null.
22 TEST(NativeLibraryTest, LoadFailureWithNullError) { 21 TEST(NativeLibraryTest, LoadFailureWithNullError) {
23 EXPECT_FALSE(LoadNativeLibrary(FilePath(kDummyLibraryPath), nullptr)); 22 EXPECT_FALSE(LoadNativeLibrary(FilePath(kDummyLibraryPath), nullptr));
24 } 23 }
25 24
26 TEST(NativeLibraryTest, GetNativeLibraryName) { 25 TEST(NativeLibraryTest, GetNativeLibraryName) {
27 const char kExpectedName[] = 26 const char kExpectedName[] =
28 #if defined(OS_IOS) 27 #if defined(OS_IOS)
29 "mylib"; 28 "mylib";
30 #elif defined(OS_MACOSX) 29 #elif defined(OS_MACOSX)
31 "mylib.dylib"; 30 "libmylib.dylib";
32 #elif defined(OS_POSIX) 31 #elif defined(OS_POSIX)
33 "libmylib.so"; 32 "libmylib.so";
34 #elif defined(OS_WIN) 33 #elif defined(OS_WIN)
35 "mylib.dll"; 34 "mylib.dll";
36 #endif 35 #endif
37 EXPECT_EQ(ASCIIToUTF16(kExpectedName), 36 EXPECT_EQ(kExpectedName, GetNativeLibraryName("mylib"));
38 GetNativeLibraryName(ASCIIToUTF16("mylib")));
39 } 37 }
40 38
41 } // namespace base 39 } // namespace base
OLDNEW
« no previous file with comments | « base/native_library_posix.cc ('k') | base/native_library_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698