Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: base/native_library_ios.mm

Issue 2048523002: Fix base::GetNativeLibraryName() for Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@native_lib_clean
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/native_library.h ('k') | base/native_library_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/native_library_ios.mm
diff --git a/base/native_library_ios.mm b/base/native_library_ios.mm
index 6ae7580d48d704882a0b2b7f65e6ae47e7a87a2f..fb1b077a0f48f3fce82867c199191334683baa00 100644
--- a/base/native_library_ios.mm
+++ b/base/native_library_ios.mm
@@ -6,6 +6,8 @@
#include "base/logging.h"
+#include "base/strings/string_util.h"
+
namespace base {
std::string NativeLibraryLoadError::ToString() const {
@@ -35,7 +37,8 @@ void* GetFunctionPointerFromNativeLibrary(NativeLibrary library,
}
// static
-string16 GetNativeLibraryName(StringPiece16 name) {
+std::string GetNativeLibraryName(StringPiece name) {
+ DCHECK(IsStringASCII(name));
return name.as_string();
}
« no previous file with comments | « base/native_library.h ('k') | base/native_library_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698