Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1357)

Unified Diff: base/native_library.h

Issue 2048523002: Fix base::GetNativeLibraryName() for Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@native_lib_clean
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/native_library_ios.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/native_library.h
diff --git a/base/native_library.h b/base/native_library.h
index 5dc4802c410df10def5e4407b29f5d015e6e1a00..b4f3a3cd1ba267000848b09c0ee9d8af7983387f 100644
--- a/base/native_library.h
+++ b/base/native_library.h
@@ -11,7 +11,6 @@
#include <string>
#include "base/base_export.h"
-#include "base/strings/string16.h"
#include "base/strings/string_piece.h"
#include "build/build_config.h"
@@ -90,10 +89,11 @@ BASE_EXPORT void* GetFunctionPointerFromNativeLibrary(NativeLibrary library,
StringPiece name);
// Returns the full platform specific name for a native library.
+// |name| must be ASCII.
// For example:
// "mylib" returns "mylib.dll" on Windows, "libmylib.so" on Linux,
-// "mylib.dylib" on Mac.
-BASE_EXPORT string16 GetNativeLibraryName(StringPiece16 name);
+// "libmylib.dylib" on Mac.
+BASE_EXPORT std::string GetNativeLibraryName(StringPiece name);
} // namespace base
« no previous file with comments | « no previous file | base/native_library_ios.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698