Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: src/interpreter/bytecode-register-optimizer.cc

Issue 2048203002: [interpreter] Minor clean-up of BytecodeSourceInfo. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@oth-0066-suppress
Patch Set: Add BytecodeSourceInfo::ForceExpressionPosition(). Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/interpreter/bytecode-register-optimizer.cc
diff --git a/src/interpreter/bytecode-register-optimizer.cc b/src/interpreter/bytecode-register-optimizer.cc
index ff5f5d0441d86e2911c57888315d902d38f1150e..ca0191ebc5e4e63f99f4aa821bbcad2fbd21dfd3 100644
--- a/src/interpreter/bytecode-register-optimizer.cc
+++ b/src/interpreter/bytecode-register-optimizer.cc
@@ -311,7 +311,9 @@ void BytecodeRegisterOptimizer::WriteToNextStage(BytecodeNode* node) const {
void BytecodeRegisterOptimizer::WriteToNextStage(
BytecodeNode* node, const BytecodeSourceInfo& source_info) const {
- node->source_info().Update(source_info);
+ if (source_info.is_valid()) {
+ node->source_info().MakeInvalidEqualTo(source_info);
+ }
next_stage_->Write(node);
}
@@ -413,8 +415,9 @@ void BytecodeRegisterOptimizer::RegisterTransfer(
void BytecodeRegisterOptimizer::EmitNopForSourceInfo(
const BytecodeSourceInfo& source_info) const {
+ DCHECK(source_info.is_valid());
BytecodeNode nop(Bytecode::kNop);
- nop.source_info().Update(source_info);
+ nop.source_info().MakeInvalidEqualTo(source_info);
WriteToNextStage(&nop);
}

Powered by Google App Engine
This is Rietveld 408576698