test/unittests/interpreter/bytecode-array-writer-unittest.cc - Issue 2048203002: [interpreter] Minor clean-up of BytecodeSourceInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/unittests/interpreter/bytecode-array-writer-unittest.cc

Issue 2048203002: [interpreter] Minor clean-up of BytecodeSourceInfo. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@oth-0066-suppress

Patch Set: Add BytecodeSourceInfo::ForceExpressionPosition(). Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« src/interpreter/bytecode-pipeline.h ('K') | « src/interpreter/bytecode-register-optimizer.cc ('k') | test/unittests/interpreter/bytecode-peephole-optimizer-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: test/unittests/interpreter/bytecode-array-writer-unittest.cc

diff --git a/test/unittests/interpreter/bytecode-array-writer-unittest.cc b/test/unittests/interpreter/bytecode-array-writer-unittest.cc

index f625edfdafd1e1739194ea1515b35b1e65dbe606..c34798416e909bd12a0a7b4a0df9c9a48fc56ba6 100644

--- a/test/unittests/interpreter/bytecode-array-writer-unittest.cc

+++ b/test/unittests/interpreter/bytecode-array-writer-unittest.cc

@@ -60,7 +60,7 @@ class BytecodeArrayWriterUnittest : public TestWithIsolateAndZone {

void BytecodeArrayWriterUnittest::Write(BytecodeNode* node,

const BytecodeSourceInfo& info) {

if (info.is_valid()) {

- node->source_info().Update(info);

+ node->source_info().MakeInvalidEqualTo(info);

}

writer()->Write(node);

}

@@ -104,7 +104,7 @@ void BytecodeArrayWriterUnittest::WriteJump(Bytecode bytecode,

const BytecodeSourceInfo& info) {

BytecodeNode node(bytecode, 0);

if (info.is_valid()) {

- node.source_info().Update(info);

+ node.source_info().MakeInvalidEqualTo(info);

}

writer()->WriteJump(&node, label);

}