Make SkDashPathEffect fail for stroke+fill style (in addition to fill style)

Make SkDashPathEffect fail for stroke+fill style (in addition to fill style)
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2048183002

Committed: https://skia.googlesource.com/skia/+/a058786ae3cd9402194de94f6658a19efe3f34ef

[bsalomon, 2016-06-08 20:46:13]

Description was changed from

==========
Make SkDashPathEffect fail for stroke+fill stye (in addition to for fill style)
==========

to

==========
Make SkDashPathEffect fail for stroke+fill stye (in addition to for fill style)
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2048183002
==========

[bsalomon, 2016-06-08 20:51:30]

bsalomon@google.com changed reviewers:
+ reed@google.com

[bsalomon, 2016-06-08 20:51:31]

The current implementation would produce the dashed path which would then be
stroked and filled, which seems like an unexpected behavior. The
SkPathEffect::filterPath() interface isn't rich enough to allow the
implementation to achieve the desired effect for dashed stroke+fill without
doing a whole lot more work in the dash code. We don't really want to promulgate
the use of stroke+fill anyway.

[reed1, 2016-06-09 10:37:47]

Assuming we don't break some odd use in Android, lgtm

[bsalomon, 2016-06-09 12:49:51]

Description was changed from

==========
Make SkDashPathEffect fail for stroke+fill stye (in addition to for fill style)
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2048183002
==========

to

==========
Make SkDashPathEffect fail for stroke+fill style (in addition to fill style)
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2048183002
==========

[bsalomon, 2016-06-09 12:50:00]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2016-06-09 12:50:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2048183002/20001

[commit-bot: I haz the power, 2016-06-09 13:03:43]

Description was changed from

==========
Make SkDashPathEffect fail for stroke+fill style (in addition to fill style)
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2048183002
==========

to

==========
Make SkDashPathEffect fail for stroke+fill style (in addition to fill style)
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2048183002

Committed:
https://skia.googlesource.com/skia/+/a058786ae3cd9402194de94f6658a19efe3f34ef
==========

[commit-bot: I haz the power, 2016-06-09 13:03:44]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/a058786ae3cd9402194de94f6658a19efe3f34ef