Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Issue 2056523002: Make GrShape capable of representing inverse filled rrects. (Closed)

Created:
4 years, 6 months ago by bsalomon
Modified:
4 years, 6 months ago
Reviewers:
egdaniel, mtklein
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@faildashstrokeandfill
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make GrShape capable of representing inverse filled rrects. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2056523002 Committed: https://skia.googlesource.com/skia/+/7049396b65660907af5292d899053280430d929a

Patch Set 1 #

Patch Set 2 : more #

Patch Set 3 : more tests #

Patch Set 4 : comments #

Patch Set 5 : Fix windows warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+383 lines, -61 lines) Patch
M src/gpu/GrShape.h View 1 2 12 chunks +46 lines, -9 lines 0 comments Download
M src/gpu/GrShape.cpp View 10 chunks +34 lines, -4 lines 0 comments Download
M tests/GrShapeTest.cpp View 1 2 3 4 11 chunks +303 lines, -48 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (5 generated)
bsalomon
4 years, 6 months ago (2016-06-09 16:15:14 UTC) #3
egdaniel
lgtm
4 years, 6 months ago (2016-06-10 14:42:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056523002/80001
4 years, 6 months ago (2016-06-10 14:48:47 UTC) #6
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://skia.googlesource.com/skia/+/7049396b65660907af5292d899053280430d929a
4 years, 6 months ago (2016-06-10 15:05:17 UTC) #8
mtklein
Any chance we can convert some stack storage to static or heap in here? Google3 ...
4 years, 6 months ago (2016-06-10 20:58:12 UTC) #10
bsalomon
4 years, 6 months ago (2016-06-11 00:20:00 UTC) #11
Message was sent while issue was closed.
On 2016/06/10 20:58:12, mtklein wrote:
> Any chance we can convert some stack storage to static or heap in here? 
Google3
> build:
> 
> third_party/skia/HEAD/tests/GrShapeTest.cpp: In function 'void
> test_rrect(skiatest::Reporter*, const SkRRect&)':
> third_party/skia/HEAD/tests/GrShapeTest.cpp:1227:1: error: the frame size of
> 63888 bytes is larger than 16384 bytes; see http://go/big_stack_frame
> [-Werror=frame-larger-than=]
> At global scope:
> cc1plus: error: unrecognized command line option "-Wno-implicit-fallthrough"
> [-Werror]
> cc1plus: all warnings being treated as errors

Yep, will do.

Powered by Google App Engine
This is Rietveld 408576698