Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2047963003: Give autogen bots on chromium.fyi and client.nacl.sdk a separate clobber step (Closed)

Created:
4 years, 6 months ago by Nico
Modified:
4 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, krasin1, bradnelson
Base URL:
https://chromium.googlesource.com/chromium/tools/build@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Give autogen bots on chromium.fyi and client.nacl.sdk a separate clobber step Some bots were converted to recipes using some script that automatically rewrites the old buildbot config. These bots don't use the regular recipes machinery, so they didn't get converted as part of the work in bug 574557. On the nacl waterfall, also remove all.sln; these bots have been building using ninja for a long time. BUG=617604 Committed: https://chromium.googlesource.com/chromium/tools/build/+/8d2793855e7f3ac1897002b5b8d8fb385f97750b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -27 lines) Patch
M scripts/slave/recipes/chromium.fyi.misc_block.recipe_autogen.py View 3 chunks +6 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.fyi.misc_block.recipe_autogen.expected/CFI_Linux_CF.json View 2 chunks +19 lines, -1 line 0 comments Download
M scripts/slave/recipes/client.nacl.sdk.recipe_autogen.py View 13 chunks +33 lines, -8 lines 0 comments Download
M scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/linux_sdk_asan_multi.json View 2 chunks +19 lines, -1 line 0 comments Download
M scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/linux_sdk_multi.json View 2 chunks +19 lines, -1 line 0 comments Download
M scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/linux_sdk_multirel.json View 2 chunks +19 lines, -1 line 0 comments Download
M scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/mac_sdk_multi.json View 2 chunks +19 lines, -1 line 0 comments Download
M scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/mac_sdk_multirel.json View 2 chunks +19 lines, -1 line 0 comments Download
M scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/windows_sdk_multi.json View 2 chunks +21 lines, -6 lines 0 comments Download
M scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/windows_sdk_multirel.json View 2 chunks +21 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Nico
dpranke: review It seems much better to convert these configs to use the normal recipes ...
4 years, 6 months ago (2016-06-08 16:31:28 UTC) #2
Dirk Pranke
hm, not sure how the CFI bot fell off my radar as something needing to ...
4 years, 6 months ago (2016-06-08 16:42:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2047963003/1
4 years, 6 months ago (2016-06-08 16:43:05 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 16:47:28 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/8d2793855e7f3ac18970...

Powered by Google App Engine
This is Rietveld 408576698