scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/mac_sdk_multi.json - Issue 2047963003: Give autogen bots on chromium.fyi and client.nacl.sdk a separate clobber step

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/mac_sdk_multi.json

Issue 2047963003: Give autogen bots on chromium.fyi and client.nacl.sdk a separate clobber step (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/linux_sdk_multirel.json ('k') | scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/mac_sdk_multirel.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/mac_sdk_multi.json

diff --git a/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/mac_sdk_multi.json b/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/mac_sdk_multi.json

index 34c60434db4a8ec4a4278cc91d686caaf12f5ef5..8ee168b31b109b7d6b6b3c3dce33c8f6729b2c87 100644

--- a/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/mac_sdk_multi.json

+++ b/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/mac_sdk_multi.json

@@ -84,6 +84,25 @@

"cmd": [

"python",

"-u",

+ "\nimport os, sys\nfrom common import chromium_utils # Error? See https://crbug.com/584783.\n\n\nif os.path.exists(sys.argv[1]):\n chromium_utils.RemoveDirectory(sys.argv[1])\n",

+ "[SLAVE_BUILD]/src/out/Release"

+ ],

+ "name": "rmtree clobber",

+ "~followup_annotations": [

+ "@@@STEP_LOG_LINE@python.inline@@@@",

+ "@@@STEP_LOG_LINE@python.inline@import os, sys@@@",

+ "@@@STEP_LOG_LINE@python.inline@from common import chromium_utils # Error? See https://crbug.com/584783.@@@",

+ "@@@STEP_LOG_LINE@python.inline@@@@",

+ "@@@STEP_LOG_LINE@python.inline@if os.path.exists(sys.argv[1]):@@@",

+ "@@@STEP_LOG_LINE@python.inline@ chromium_utils.RemoveDirectory(sys.argv[1])@@@",

+ "@@@STEP_LOG_END@python.inline@@@"

+ ]

+ },

+ {

+ "cmd": [

+ "python",

+ "-u",

"[BUILD]/scripts/slave/runhooks_wrapper.py"

"env": {

@@ -113,7 +132,6 @@

"[BUILD]/scripts/slave/compile.py",

"--target",

"Release",

- "--clobber",

"--build-tool=ninja",

"--compiler=goma-clang",

"--",