Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1337)

Unified Diff: content/shell/browser/shell_devtools_frontend.cc

Issue 2047833002: DevTools: introduce browser domain for basic target discovery. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments addressed Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/browser/devtools_agent_host.h ('k') | headless/lib/browser/headless_devtools_client_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/browser/shell_devtools_frontend.cc
diff --git a/content/shell/browser/shell_devtools_frontend.cc b/content/shell/browser/shell_devtools_frontend.cc
index e580e28a7a9ae6ac5b290acf52a76a40b6b8758a..982337a0155b50e36249f6ac5f9bd3e7c6a8be63 100644
--- a/content/shell/browser/shell_devtools_frontend.cc
+++ b/content/shell/browser/shell_devtools_frontend.cc
@@ -143,7 +143,7 @@ void ShellDevToolsFrontend::Close() {
void ShellDevToolsFrontend::DisconnectFromTarget() {
if (!agent_host_)
return;
- agent_host_->DetachClient();
+ agent_host_->DetachClient(this);
agent_host_ = NULL;
}
@@ -177,7 +177,7 @@ void ShellDevToolsFrontend::DocumentAvailableInMainFrame() {
void ShellDevToolsFrontend::WebContentsDestroyed() {
if (agent_host_)
- agent_host_->DetachClient();
+ agent_host_->DetachClient(this);
delete this;
}
@@ -204,7 +204,7 @@ void ShellDevToolsFrontend::HandleMessageFromDevToolsFrontend(
std::string protocol_message;
if (!params->GetString(0, &protocol_message))
return;
- agent_host_->DispatchProtocolMessage(protocol_message);
+ agent_host_->DispatchProtocolMessage(this, protocol_message);
} else if (method == "loadCompleted") {
web_contents()->GetMainFrame()->ExecuteJavaScriptForTests(
base::ASCIIToUTF16("DevToolsAPI.setUseSoftMenu(true);"));
« no previous file with comments | « content/public/browser/devtools_agent_host.h ('k') | headless/lib/browser/headless_devtools_client_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698