headless/lib/browser/headless_devtools_client_impl.cc - Issue 2047833002: DevTools: introduce browser domain for basic target discovery.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: headless/lib/browser/headless_devtools_client_impl.cc

Issue 2047833002: DevTools: introduce browser domain for basic target discovery. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/browser/shell_devtools_frontend.cc ('k') | third_party/WebKit/Source/core/inspector/browser_protocol.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: headless/lib/browser/headless_devtools_client_impl.cc

diff --git a/headless/lib/browser/headless_devtools_client_impl.cc b/headless/lib/browser/headless_devtools_client_impl.cc

index 2f662bb669550ec6b7ff2e075844fddebd0c4f66..41aa4fc69940fe7a4aff31b8aa66d28d81b811fa 100644

--- a/headless/lib/browser/headless_devtools_client_impl.cc

+++ b/headless/lib/browser/headless_devtools_client_impl.cc

@@ -72,7 +72,7 @@ void HeadlessDevToolsClientImpl::AttachToHost(

void HeadlessDevToolsClientImpl::DetachFromHost(

content::DevToolsAgentHost* agent_host) {

DCHECK_EQ(agent_host_, agent_host);

- agent_host_->DetachClient();

+ agent_host_->DetachClient(this);

agent_host_ = nullptr;

pending_messages_.clear();

}

@@ -272,7 +272,7 @@ void HeadlessDevToolsClientImpl::FinalizeAndSendMessage(

std::string json_message;

base::JSONWriter::Write(*message, &json_message);

pending_messages_[id] = Callback(callback);

- agent_host_->DispatchProtocolMessage(json_message);

+ agent_host_->DispatchProtocolMessage(this, json_message);

}

template <typename CallbackType>

« no previous file with comments | « content/shell/browser/shell_devtools_frontend.cc ('k') | third_party/WebKit/Source/core/inspector/browser_protocol.json » ('j') | no next file with comments »