content/browser/devtools/protocol/service_worker_handler.cc - Issue 2047833002: DevTools: introduce browser domain for basic target discovery.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/protocol/service_worker_handler.cc

Issue 2047833002: DevTools: introduce browser domain for basic target discovery. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/protocol/devtools_protocol_browsertest.cc ('k') | content/browser/devtools/render_frame_devtools_agent_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/protocol/service_worker_handler.cc

diff --git a/content/browser/devtools/protocol/service_worker_handler.cc b/content/browser/devtools/protocol/service_worker_handler.cc

index e008b685875e55800eb00e814119f6635e1d6cd0..60f0241bb234140a1934d8995e2cb209a686f9d0 100644

--- a/content/browser/devtools/protocol/service_worker_handler.cc

+++ b/content/browser/devtools/protocol/service_worker_handler.cc

@@ -387,7 +387,7 @@ Response ServiceWorkerHandler::Disable() {

ServiceWorkerDevToolsManager::GetInstance()->RemoveObserver(this);

ClearForceUpdate();

for (const auto& pair : attached_hosts_)

- pair.second->DetachClient();

+ pair.second->DetachClient(this);

attached_hosts_.clear();

DCHECK(context_watcher_);

context_watcher_->Stop();

@@ -684,7 +684,7 @@ void ServiceWorkerHandler::ReportWorkerTerminated(

auto it = attached_hosts_.find(host->GetId());

if (it == attached_hosts_.end())

return;

- host->DetachClient();

+ host->DetachClient(this);

client_->WorkerTerminated(WorkerTerminatedParams::Create()->

set_worker_id(host->GetId()));

attached_hosts_.erase(it);