content/browser/devtools/protocol/devtools_protocol_browsertest.cc - Issue 2047833002: DevTools: introduce browser domain for basic target discovery.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/protocol/devtools_protocol_browsertest.cc

Issue 2047833002: DevTools: introduce browser domain for basic target discovery. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/protocol/browser_handler.cc ('k') | content/browser/devtools/protocol/service_worker_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/protocol/devtools_protocol_browsertest.cc

diff --git a/content/browser/devtools/protocol/devtools_protocol_browsertest.cc b/content/browser/devtools/protocol/devtools_protocol_browsertest.cc

index 0a243395c5f5800c72a2551e2733cdb6cfb30244..60be9a7038a8f46679b7c3800bd3f196544eb2b6 100644

--- a/content/browser/devtools/protocol/devtools_protocol_browsertest.cc

+++ b/content/browser/devtools/protocol/devtools_protocol_browsertest.cc

@@ -122,7 +122,7 @@ class DevToolsProtocolTest : public ContentBrowserTest,

std::string json_command;

base::JSONWriter::Write(command, &json_command);

- agent_host_->DispatchProtocolMessage(json_command);

+ agent_host_->DispatchProtocolMessage(this, json_command);

// Some messages are dispatched synchronously.

// Only run loop if we are not finished yet.

if (in_dispatch_ && wait) {

@@ -164,7 +164,7 @@ class DevToolsProtocolTest : public ContentBrowserTest,

void TearDownOnMainThread() override {

if (agent_host_) {

- agent_host_->DetachClient();

+ agent_host_->DetachClient(this);

agent_host_ = nullptr;

}