Use ICU data file on Android WebView.

Use ICU data file on Android WebView.

The Android WebView uses the system ICU on target anyway, so this only
affects the host build of ICU used to build the host V8. This means the
flag is now enabled on all platforms by default and no longer needs to
be conditional.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258278

[Torne, 2014-03-19 17:38:48]

Hi Andrew, Jungshik,

It looks like there's no good reason why we're still using a different approach
here for WebView; I'm sending this to trybots just to double-check.

[Torne, 2014-03-19 17:45:38]

Yup, this works on android_aosp, so we should be able to go ahead with this.
Okay with you?

[Andrew Hayden (chromium.org), 2014-03-19 17:55:49]

Hooray for conformity. CONFORM! CONFORM!

LGTM

[Torne, 2014-03-19 18:01:06]

The CQ bit was checked by torne@chromium.org

[commit-bot: I haz the power, 2014-03-19 18:04:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/torne@chromium.org/204783003/1

[commit-bot: I haz the power, 2014-03-19 18:04:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-19 18:04:53]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[jungshik at Google, 2014-03-19 20:27:04]

Lgtm

[Torne, 2014-03-19 20:27:34]

The CQ bit was checked by torne@chromium.org

[commit-bot: I haz the power, 2014-03-19 20:28:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/torne@chromium.org/204783003/1

[commit-bot: I haz the power, 2014-03-19 20:28:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-19 20:28:23]

Failed to apply patch for build/common.gypi:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file build/common.gypi
  Hunk #1 FAILED at 837.
  Hunk #2 succeeded at 1002 (offset 4 lines).
  Hunk #3 succeeded at 1304 (offset 4 lines).
  Hunk #4 succeeded at 1390 (offset 4 lines).
  1 out of 4 hunks FAILED -- saving rejects to file build/common.gypi.rej

Patch:       build/common.gypi
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index
dfc7abee87ca0e9a935b5931f75ea436fb7b1661..f0977449c1a81d15a5e7520077c6cdb0f332d1a3
100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -837,15 +837,6 @@
           'remoting%': 0,
           'enable_printing%': 0,
         }],
-
-        # By default, use ICU data file (icudtl.dat) on all platforms
-        # except when building Android WebView.
-        # TODO(jshin): Handle 'use_system_icu' on Linux (Chromium).
-        ['android_webview_build==0', {
-          'icu_use_data_file_flag%' : 1,
-        }, {
-          'icu_use_data_file_flag%' : 0,
-        }],
       ],
 
       # Set this to 1 to enable use of concatenated impulse responses
@@ -998,7 +989,6 @@
     'use_libjpeg_turbo%': '<(use_libjpeg_turbo)',
     'use_system_libjpeg%': '<(use_system_libjpeg)',
     'android_webview_build%': '<(android_webview_build)',
-    'icu_use_data_file_flag%': '<(icu_use_data_file_flag)',
     'gyp_managed_install%': 0,
     'create_standalone_apk%': 1,
     'enable_app_list%': '<(enable_app_list)',
@@ -1301,6 +1291,9 @@
     # IPC fuzzer is disabled by default.
     'enable_ipc_fuzzer%': 0,
 
+    # By default, use ICU data file (icudtl.dat) on all platforms.
+    # TODO(jshin): Handle 'use_system_icu' on Linux (Chromium).
+    'icu_use_data_file_flag%' : 1,
 
     # Force disable libstdc++ debug mode.
     'disable_glibcxx_debug%': 0,
@@ -1384,7 +1377,6 @@
       ['OS=="ios"', {
         'disable_nacl%': 1,
         'enable_background%': 0,
-        'icu_use_data_file_flag%': 1,
         'input_speech%': 0,
         'use_system_libxml%': 1,
         'use_system_sqlite%': 1,

[Torne, 2014-03-20 10:20:13]

The CQ bit was checked by torne@chromium.org

[commit-bot: I haz the power, 2014-03-20 10:20:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/torne@chromium.org/204783003/20001

[commit-bot: I haz the power, 2014-03-20 14:35:12]

Change committed as 258278