Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 2047743002: [css-flexbox] logical widths are always definite. (Closed)

Created:
4 years, 6 months ago by cbiesinger
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

[css-flexbox] logical widths are always definite. Per guidance from the CSS working group we should always treat widths as definite, which allows us to simplify & speed up some code in Flexbox. See also https://lists.w3.org/Archives/Public/www-style/2016May/0135.html which I believe covers all the cases where they might not be (=shrinkwrapping). Because this means that for widths we always use the actual width of the element for percentage calculations, we can remove some code from LayoutBox too. BUG=595361 Review-Url: https://codereview.chromium.org/2022553002 Cr-Commit-Position: refs/heads/master@{#396584} (cherry picked from commit 237e6796e049700ccb7adf105d3f95ba9572e66c) Committed: https://chromium.googlesource.com/chromium/src/+/41265a04a2f3c3db5988012aae575b3667639674

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -53 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 4 chunks +2 lines, -43 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
cbiesinger
4 years, 6 months ago (2016-06-07 17:58:49 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
41265a04a2f3c3db5988012aae575b3667639674.

Powered by Google App Engine
This is Rietveld 408576698