Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2022553002: [css-flexbox] logical widths are always definite. (Closed)

Created:
4 years, 6 months ago by cbiesinger
Modified:
4 years, 6 months ago
Reviewers:
eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, dgrogan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-flexbox] logical widths are always definite. Per guidance from the CSS working group we should always treat widths as definite, which allows us to simplify & speed up some code in Flexbox. See also https://lists.w3.org/Archives/Public/www-style/2016May/0135.html which I believe covers all the cases where they might not be (=shrinkwrapping). Because this means that for widths we always use the actual width of the element for percentage calculations, we can remove some code from LayoutBox too. BUG=595361 Committed: https://crrev.com/237e6796e049700ccb7adf105d3f95ba9572e66c Cr-Commit-Position: refs/heads/master@{#396584}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -53 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 4 chunks +2 lines, -43 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2022553002/1
4 years, 6 months ago (2016-05-27 20:16:54 UTC) #2
cbiesinger
4 years, 6 months ago (2016-05-27 20:19:04 UTC) #5
eae
Nice! LGTM
4 years, 6 months ago (2016-05-27 20:44:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2022553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2022553002/1
4 years, 6 months ago (2016-05-27 21:00:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-27 22:20:29 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 22:22:37 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/237e6796e049700ccb7adf105d3f95ba9572e66c
Cr-Commit-Position: refs/heads/master@{#396584}

Powered by Google App Engine
This is Rietveld 408576698