MD Settings: Spellcheck subsection secondary text

MD Settings: Spellcheck subsection secondary text

Show the enabled spellcheck languages, if any. The list is comma-separated
but cut off after 2 entries per issue 617364.

Screenshot: https://bugs.chromium.org/p/chromium/issues/attachment?aid=238202&inline=1

R=dbeam@chromium.org
BUG=617364
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/9fefdaff86db5b945216f1f7ae7b03fb4ad06b9a
Cr-Commit-Position: refs/heads/master@{#399579}

[michaelpg, 2016-06-07 23:56:32]

Description was changed from

==========
MD Settings: Spellcheck subsection secondary text

Show the enabled spellcheck languages, if any. The list is comma-separated
but cut off after 2 entries per issue 617364.

R=dbeam@chromium.org
BUG=617364
==========

to

==========
MD Settings: Spellcheck subsection secondary text

Show the enabled spellcheck languages, if any. The list is comma-separated
but cut off after 2 entries per issue 617364.

R=dbeam@chromium.org
BUG=617364
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[michaelpg, 2016-06-07 23:58:02]

Description was changed from

==========
MD Settings: Spellcheck subsection secondary text

Show the enabled spellcheck languages, if any. The list is comma-separated
but cut off after 2 entries per issue 617364.

R=dbeam@chromium.org
BUG=617364
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Spellcheck subsection secondary text

Show the enabled spellcheck languages, if any. The list is comma-separated
but cut off after 2 entries per issue 617364.

Screenshot: https://goo.gl/wr9TXk

R=dbeam@chromium.org
BUG=617364
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[michaelpg, 2016-06-07 23:59:06]

Dan, PTAL. Is there a better way to format "choice" strings like this from
JavaScript? I suppose it's doable with ICU format in C++ but it seemed wasteful
to make a round-trip "api" call for a string update.

[michaelpg, 2016-06-07 23:59:58]

Description was changed from

==========
MD Settings: Spellcheck subsection secondary text

Show the enabled spellcheck languages, if any. The list is comma-separated
but cut off after 2 entries per issue 617364.

Screenshot: https://goo.gl/wr9TXk

R=dbeam@chromium.org
BUG=617364
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Spellcheck subsection secondary text

Show the enabled spellcheck languages, if any. The list is comma-separated
but cut off after 2 entries per issue 617364.

Screenshot:
https://bugs.chromium.org/p/chromium/issues/attachment?aid=238202&inline=1

R=dbeam@chromium.org
BUG=617364
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-06-08 00:10:20]

the implementation lgtm, but maybe ask jshin@ how well this localizes?

[michaelpg, 2016-06-08 00:43:43]

michaelpg@chromium.org changed reviewers:
+ jshin@chromium.org

[michaelpg, 2016-06-08 00:43:43]

michaelpg@chromium.org changed required reviewers:
+ dbeam@chromium.org

[michaelpg, 2016-06-08 00:43:43]

jshin: WDYT about this i18n? Basically depending on the # of items, we want to
present the list in one of four ways:

* "Item1"
* "Item1, Item2"
* "Item1, Item2, and 1 other"
* "Item1, Item2, and 2 others" (or 3, 4, ...)

Can I get away with these message strings? The potential problems I see:

* Plural distinction is iffy (what if a language uses a different form for 3
items?)
* The Items are translated outside the list and subbed in (we can't really fix
that)

In this CL, the "items" happen to be the names of languages, hope that's not too
confusing!

[jungshik at Google, 2016-06-12 10:24:56]

Sorry for the  late reply (I wrote a long reply, but just lost it. )

On 2016/06/08 00:43:43, michaelpg wrote:
> jshin: WDYT about this i18n? Basically depending on the # of items, we want to
> present the list in one of four ways:

With plural/complex message formatting not yet available in Chrome's WebUI/JS,
there's not much we
can do here. 

A common trick is to use a tabular format when plural format is not available,
but the tabular format seems
not great in this context (based on your screenshot). 

> 
> * "Item1"
> * "Item1, Item2"
> * "Item1, Item2, and 1 other"
> * "Item1, Item2, and 2 others" (or 3, 4, ...)
> 
> Can I get away with these message strings? The potential problems I see:
> 
> * Plural distinction is iffy (what if a language uses a different form for 3
> items?)
> * The Items are translated outside the list and subbed in (we can't really fix
> that)

In some languages even 'and' might inflect depending on the gender (or other
attributes) of <lang 2>, but there's not much
we can do here. (the old non-MD UI does not have that problem ;-) ). 
 
Perhaps, you may as well add a TODO comment about plural (when it becomes
available, use that). 

With that, LGTM

[jungshik at Google, 2016-06-13 06:28:17]

> * "Item1"
> * "Item1, Item2"
> * "Item1, Item2, and 1 other"
> * "Item1, Item2, and 2 others" (or 3, 4, ...)

How about this?

if N==1, 
  "Lang1"     
if N==2
  "Lang1" and "Lang2"
if N >= 2
  "Lang1", "Lang2", ...  (total: N)
 
Then, you can avoid an issue with plural.

[michaelpg, 2016-06-13 21:20:32]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2016-06-13 21:20:34]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org,
jshin@chromium.org
Link to the patchset: https://codereview.chromium.org/2047733003/#ps40001
(title: "TODO")

[michaelpg, 2016-06-13 21:20:55]

Committing with a TODO. Thanks!

On 2016/06/13 06:28:17, jungshik - ooo until Jul 5 wrote:
> > * "Item1"
> > * "Item1, Item2"
> > * "Item1, Item2, and 1 other"
> > * "Item1, Item2, and 2 others" (or 3, 4, ...)
> 
> How about this?
> 
> if N==1, 
>   "Lang1"     
> if N==2
>   "Lang1" and "Lang2"
> if N >= 2
>   "Lang1", "Lang2", ...  (total: N)
>  
> Then, you can avoid an issue with plural.

I'll suggest that in the bug.

[commit-bot: I haz the power, 2016-06-13 21:21:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2047733003/40001

[commit-bot: I haz the power, 2016-06-13 22:33:22]

Description was changed from

==========
MD Settings: Spellcheck subsection secondary text

Show the enabled spellcheck languages, if any. The list is comma-separated
but cut off after 2 entries per issue 617364.

Screenshot:
https://bugs.chromium.org/p/chromium/issues/attachment?aid=238202&inline=1

R=dbeam@chromium.org
BUG=617364
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Spellcheck subsection secondary text

Show the enabled spellcheck languages, if any. The list is comma-separated
but cut off after 2 entries per issue 617364.

Screenshot:
https://bugs.chromium.org/p/chromium/issues/attachment?aid=238202&inline=1

R=dbeam@chromium.org
BUG=617364
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-06-13 22:33:27]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-13 22:33:31]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-13 22:34:40]

Description was changed from

==========
MD Settings: Spellcheck subsection secondary text

Show the enabled spellcheck languages, if any. The list is comma-separated
but cut off after 2 entries per issue 617364.

Screenshot:
https://bugs.chromium.org/p/chromium/issues/attachment?aid=238202&inline=1

R=dbeam@chromium.org
BUG=617364
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Spellcheck subsection secondary text

Show the enabled spellcheck languages, if any. The list is comma-separated
but cut off after 2 entries per issue 617364.

Screenshot:
https://bugs.chromium.org/p/chromium/issues/attachment?aid=238202&inline=1

R=dbeam@chromium.org
BUG=617364
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/9fefdaff86db5b945216f1f7ae7b03fb4ad06b9a
Cr-Commit-Position: refs/heads/master@{#399579}
==========

[commit-bot: I haz the power, 2016-06-13 22:34:42]

Patchset 3 (id:??) landed as
https://crrev.com/9fefdaff86db5b945216f1f7ae7b03fb4ad06b9a
Cr-Commit-Position: refs/heads/master@{#399579}