Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6140)

Unified Diff: chrome/browser/resources/settings/languages_page/languages_page.js

Issue 2047733003: MD Settings: Spellcheck subsection secondary text (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@FixLanuageStrings
Patch Set: TODO Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/languages_page/languages_page.js
diff --git a/chrome/browser/resources/settings/languages_page/languages_page.js b/chrome/browser/resources/settings/languages_page/languages_page.js
index b2be1d210cfe9a079077c1e3f65e43e36142fdf3..cd6cfb8c79e5fa28300b7e676df75702be017100 100644
--- a/chrome/browser/resources/settings/languages_page/languages_page.js
+++ b/chrome/browser/resources/settings/languages_page/languages_page.js
@@ -163,6 +163,44 @@ Polymer({
},
/**
+ * Returns the secondary text for the spell check subsection based on the
+ * enabled spell check languages, listing at most 2 languages.
+ * @return {string}
+ * @private
+ */
+ getSpellCheckSecondaryText_: function() {
+ var enabledSpellCheckLanguages =
+ this.languages.enabled.filter(function(languageState) {
+ return languageState.spellCheckEnabled &&
+ languageState.language.supportsSpellcheck;
+ });
+ switch (enabledSpellCheckLanguages.length) {
+ case 0:
+ return '';
+ case 1:
+ return enabledSpellCheckLanguages[0].language.displayName;
+ case 2:
+ return loadTimeData.getStringF(
+ 'spellCheckSummaryTwoLanguages',
+ enabledSpellCheckLanguages[0].language.displayName,
+ enabledSpellCheckLanguages[1].language.displayName);
+ case 3:
+ // "foo, bar, and 1 other"
+ return loadTimeData.getStringF(
+ 'spellCheckSummaryThreeLanguages',
+ enabledSpellCheckLanguages[0].language.displayName,
+ enabledSpellCheckLanguages[1].language.displayName);
+ default:
+ // "foo, bar, and [N-2] others"
+ return loadTimeData.getStringF(
+ 'spellCheckSummaryMultipleLanguages',
+ enabledSpellCheckLanguages[0].language.displayName,
+ enabledSpellCheckLanguages[1].language.displayName,
+ (enabledSpellCheckLanguages.length - 2).toLocaleString());
+ }
+ },
+
+ /**
* Opens the Custom Dictionary page.
* @private
*/

Powered by Google App Engine
This is Rietveld 408576698