tools/android/loading/queuing_lens.py - Issue 2047463002: Set tracing categories explicitly in Clovis and Sandwich

Unified Diff: tools/android/loading/queuing_lens.py

Issue 2047463002: Set tracing categories explicitly in Clovis and Sandwich (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/android/loading/loading_trace.py ('k') | tools/android/loading/sandwich_metrics_unittest.py » ('j') | tools/android/loading/sandwich_runner.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/android/loading/queuing_lens.py

diff --git a/tools/android/loading/queuing_lens.py b/tools/android/loading/queuing_lens.py

index 268407a31d8f7fc7b562bb2f037a0fec4084dd52..97f87dc90ec0df9572f1f0d2121a7730a3235f06 100644

--- a/tools/android/loading/queuing_lens.py

+++ b/tools/android/loading/queuing_lens.py

@@ -12,12 +12,12 @@ import collections

import itertools

import logging

-import tracing

+import clovis_constants

class QueuingLens(object):

"""Attaches queuing related trace events to request objects."""

- QUEUING_CATEGORY = tracing.QUEUING_CATEGORY

+ QUEUING_CATEGORY = clovis_constants.QUEUING_CATEGORY

blundell 2016/06/06 16:06:38 nit: maybe this should still be defined in tracing

gabadie 2016/06/06 16:17:30 Curious: why would only this category be defined i

pasko 2016/06/06 17:30:52 I am concerned with clovis_constants.py and tracin

gabadie 2016/06/06 17:37:10 To me it just looks fine as is.

ASYNC_NAME = 'ScheduledResourceRequest'

READY_NAME = 'ScheduledResourceRequest.Ready'

SET_PRIORITY_NAME = 'ScheduledResourceRequest.SetPriority'

« no previous file with comments | « tools/android/loading/loading_trace.py ('k') | tools/android/loading/sandwich_metrics_unittest.py » ('j') | tools/android/loading/sandwich_runner.py » ('J')