Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: tools/android/loading/loading_trace.py

Issue 2047463002: Set tracing categories explicitly in Clovis and Sandwich (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/android/loading/loading_trace.py
diff --git a/tools/android/loading/loading_trace.py b/tools/android/loading/loading_trace.py
index 0804e27927d9c53b9a308e1dd0c4cad0e6545462..c170e6b8aab81dbef58758c90c7f80f1fb0e1aa2 100644
--- a/tools/android/loading/loading_trace.py
+++ b/tools/android/loading/loading_trace.py
@@ -76,7 +76,7 @@ class LoadingTrace(object):
@classmethod
def RecordUrlNavigation(
- cls, url, connection, chrome_metadata, additional_categories=None,
+ cls, url, connection, chrome_metadata, categories,
timeout_seconds=devtools_monitor.DEFAULT_TIMEOUT_SECONDS):
"""Create a loading trace by using controller to fetch url.
@@ -84,8 +84,7 @@ class LoadingTrace(object):
url: (str) url to fetch.
connection: An opened devtools connection.
chrome_metadata: Dictionary of chrome metadata.
- additional_categories: ([str] or None) TracingTrack additional categories
- to capture.
+ categories: as in tracing.TracingTrack
timeout_seconds: monitoring connection timeout in seconds.
Returns:
@@ -93,9 +92,7 @@ class LoadingTrace(object):
"""
page = page_track.PageTrack(connection)
request = request_track.RequestTrack(connection)
- trace = tracing.TracingTrack(
- connection,
- additional_categories=additional_categories)
+ trace = tracing.TracingTrack(connection, categories)
start_date_str = datetime.datetime.utcnow().isoformat()
seconds_since_epoch=time.time()
connection.MonitorUrl(url, timeout_seconds=timeout_seconds)

Powered by Google App Engine
This is Rietveld 408576698