Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 2047443002: Use intptr_t for onTouch argument. (Closed)

Created:
4 years, 6 months ago by jvanverth1
Modified:
4 years, 6 months ago
Reviewers:
liyuqian
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use intptr_t for onTouch argument. On 64-bit platforms, casting int to void* is not valid. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2047443002 Committed: https://skia.googlesource.com/skia/+/814e38d5c11e4b71b2c87d1e1fe7bc8e8d688288

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M tools/viewer/Viewer.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/viewer/Viewer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/viewer/sk_app/Window.h View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/viewer/sk_app/Window.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
jvanverth1
4 years, 6 months ago (2016-06-06 15:02:14 UTC) #3
liyuqian
On 2016/06/06 15:02:14, jvanverth1 wrote: lgtm. This CL compiles and runs in my system.
4 years, 6 months ago (2016-06-06 15:10:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2047443002/1
4 years, 6 months ago (2016-06-06 15:27:30 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 15:48:50 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/814e38d5c11e4b71b2c87d1e1fe7bc8e8d688288

Powered by Google App Engine
This is Rietveld 408576698