Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2047373002: Moves ShellObserver to ash/common (Closed)

Created:
4 years, 6 months ago by sky
Modified:
4 years, 6 months ago
CC:
aboxhall+watch_chromium.org, chromium-reviews, davemoore+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chromium.org, je_julie, kalyank, lhchavez+watch_chromium.org, mlamouri+watch-notifications_chromium.org, mlamouri+watch-screen-orientation_chromium.org, nektar+watch_chromium.org, oshima+watch_chromium.org, Peter Beverloo, posciak+watch_chromium.org, sadrul, tfarina, yusukes+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -119 lines) Patch
M ash/accelerators/accelerator_interactive_uitest_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/app_list/app_list_presenter_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/aura/wm_root_window_controller_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/aura/wm_shell_aura.h View 1 chunk +1 line, -1 line 0 comments Download
A + ash/common/shell_observer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/desktop_background/desktop_background_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/display_change_observer_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/projecting_observer_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/screen_orientation_controller_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/frame/custom_frame_view_ash.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/high_contrast/high_contrast_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/root_window_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_layout_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_locking_manager.h View 1 chunk +1 line, -1 line 0 comments Download
D ash/shell_observer.h View 1 chunk +0 lines, -76 lines 0 comments Download
M ash/system/cast/tray_cast.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/brightness/tray_brightness.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/rotation/tray_rotation_lock.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/screen_security/screen_capture_tray_item.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/session/logout_confirmation_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/overview/overview_button_tray.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/toast/toast_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray_accessibility.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/web_notification/ash_popup_alignment_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/utility/screenshot_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/virtual_keyboard_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/lock_state_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/maximize_mode/maximize_mode_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/overlay_event_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/panels/attached_panel_window_targeter.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/screen_dimmer.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/video_detector.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_layout_manager_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/display_rotation_default_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/preferences.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/login_state_notification_blocker_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/touch_view_controller_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M components/arc/window_manager/arc_window_manager_bridge.h View 1 chunk +1 line, -1 line 0 comments Download
M components/exo/wayland/server.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
sky
TBR for file move
4 years, 6 months ago (2016-06-08 16:10:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2047373002/1
4 years, 6 months ago (2016-06-08 16:11:12 UTC) #5
Luis Héctor Chávez
lgtm for components/arc/
4 years, 6 months ago (2016-06-08 16:14:20 UTC) #7
reveman
lgtm
4 years, 6 months ago (2016-06-08 16:57:54 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 17:01:04 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/529ff5dbe8e5570aef08e6d678c4de6affe16d8e Cr-Commit-Position: refs/heads/master@{#398603}
4 years, 6 months ago (2016-06-08 17:02:49 UTC) #12
James Cook
4 years, 6 months ago (2016-06-08 17:40:25 UTC) #13
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698