Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 2047313004: [Blink, HTMLMediaElement] Use the resolver to reject the play promise with exception. (Closed)

Created:
4 years, 6 months ago by whywhat
Modified:
4 years, 6 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Blink, HTMLMediaElement] Fix ASSERT in ScriptPromiseResolver dtor Don't get promise() from the resolver if it's not used. BUG=618429 TEST=the test page from the bug. Committed: https://crrev.com/08c6f401940f2b255514c1380ded3c01fc9f7fa2 Cr-Commit-Position: refs/heads/master@{#398887}

Patch Set 1 #

Patch Set 2 : Even simpler fix #

Patch Set 3 : Revert to the original fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 16 (6 generated)
whywhat
Even simpler fix
4 years, 6 months ago (2016-06-08 20:18:32 UTC) #1
whywhat
PTaL
4 years, 6 months ago (2016-06-08 20:19:35 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2047313004/20001
4 years, 6 months ago (2016-06-08 20:19:47 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/235717)
4 years, 6 months ago (2016-06-09 01:16:01 UTC) #8
whywhat
Revert to the original fix
4 years, 6 months ago (2016-06-09 13:47:08 UTC) #9
mlamouri (slow - plz ping)
lgtm
4 years, 6 months ago (2016-06-09 13:50:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2047313004/40001
4 years, 6 months ago (2016-06-09 13:50:48 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-09 15:19:19 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-09 15:19:29 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 15:21:11 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/08c6f401940f2b255514c1380ded3c01fc9f7fa2
Cr-Commit-Position: refs/heads/master@{#398887}

Powered by Google App Engine
This is Rietveld 408576698