Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

Issue 2047313004: [Blink, HTMLMediaElement] Use the resolver to reject the play promise with exception. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert to the original fix Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
index 441ee5b55a8b6e020d888087c1062bc553bea0e0..103815e6a8ebe8ac8b9d044b19ae1ba614364565 100644
--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
@@ -2048,7 +2048,8 @@ ScriptPromise HTMLMediaElement::playForBindings(ScriptState* scriptState)
default:
NOTREACHED();
}
- return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(code.get(), message));
+ resolver->reject(DOMException::create(code.get(), message));
+ return promise;
}
return promise;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698