Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Unified Diff: Source/core/rendering/RenderImageResource.cpp

Issue 20473002: Update RenderImage when the image src is cleared (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/core/loader/ImageLoader.cpp ('K') | « Source/core/loader/ImageLoader.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderImageResource.cpp
diff --git a/Source/core/rendering/RenderImageResource.cpp b/Source/core/rendering/RenderImageResource.cpp
index d6504f7b23d41e272a1e9f07cc365f7f4293be9e..c50e59756398357c6e1fc9de3ade44e667b3b457 100644
--- a/Source/core/rendering/RenderImageResource.cpp
+++ b/Source/core/rendering/RenderImageResource.cpp
@@ -30,6 +30,7 @@
#include "core/loader/cache/CachedImage.h"
#include "core/platform/graphics/Image.h"
+#include "core/rendering/RenderImage.h"
#include "core/rendering/RenderObject.h"
namespace WebCore {
@@ -73,6 +74,13 @@ void RenderImageResource::setCachedImage(CachedImage* newImage)
m_cachedImage->addClient(m_renderer);
if (m_cachedImage->errorOccurred())
m_renderer->imageChanged(m_cachedImage.get());
+ } else if (m_renderer->isImage() && m_renderer->isRenderImage()) {
esprehn 2013/07/26 03:18:17 Checking isRenderImage() should be enough here.
+ // This is the case where the URL is empty.
+ // Clears old image content off the screen.
+ RenderImage* renderImage = toRenderImage(m_renderer);
+ renderImage->setImageSizeForAltText();
+ renderImage->setNeedsLayoutAndPrefWidthsRecalc();
+ renderImage->scheduleRelayout();
esprehn 2013/07/26 03:18:17 You don't manually need to call scheduleRelayout()
}
}
« Source/core/loader/ImageLoader.cpp ('K') | « Source/core/loader/ImageLoader.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698