Update RenderImage when the image src is cleared

Source/core/rendering/RenderImageResource.cpp

 /*
  * Copyright (C) 1999 Lars Knoll <knoll@kde.org>
  * Copyright (C) 1999 Antti Koivisto <koivisto@kde.org>
  * Copyright (C) 2000 Dirk Mueller <mueller@kde.org>
  * Copyright (C) 2006 Allan Sandfeld Jensen <kde@carewolf.com>
  * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
  * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2010 Google Inc. All rights reserved.
  * Copyright (C) 2010 Patrick Gansterer <paroga@paroga.com>
  *
@@ skipping 12 matching lines @@
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  *
  */
 
 #include "config.h"
 #include "core/rendering/RenderImageResource.h"
 
 #include "core/loader/cache/CachedImage.h"
 #include "core/platform/graphics/Image.h"
+#include "core/rendering/RenderImage.h"
 #include "core/rendering/RenderObject.h"
 
 namespace WebCore {
 
 RenderImageResource::RenderImageResource()
     : m_renderer(0)
     , m_cachedImage(0)
 {
 }
 
@@ skipping 23 matching lines @@
     if (m_cachedImage == newImage)
         return;
 
     if (m_cachedImage)
         m_cachedImage->removeClient(m_renderer);
     m_cachedImage = newImage;
     if (m_cachedImage) {
         m_cachedImage->addClient(m_renderer);
         if (m_cachedImage->errorOccurred())
             m_renderer->imageChanged(m_cachedImage.get());
+    } else if (m_renderer->isImage() && m_renderer->isRenderImage()) {

[esprehn, 2013/07/26 03:18:17]

Checking isRenderImage() should be enough here.

+        // This is the case where the URL is empty.
+        // Clears old image content off the screen.
+        RenderImage* renderImage = toRenderImage(m_renderer);
+        renderImage->setImageSizeForAltText();
+        renderImage->setNeedsLayoutAndPrefWidthsRecalc();
+        renderImage->scheduleRelayout();

[esprehn, 2013/07/26 03:18:17]

You don't manually need to call scheduleRelayout(). Doing setNeedsLayout is
enough.

     }
 }
 
 void RenderImageResource::resetAnimation()
 {
     ASSERT(m_renderer);
 
     if (!m_cachedImage)
         return;
 
     image()->resetAnimation();
 
     if (!m_renderer->needsLayout())
         m_renderer->repaint();
 }
 
 void RenderImageResource::setContainerSizeForRenderer(const IntSize& imageContainerSize)
 {
     ASSERT(m_renderer);
     if (m_cachedImage)
         m_cachedImage->setContainerSizeForRenderer(m_renderer, imageContainerSize, m_renderer->style()->effectiveZoom());
 }
 
 Image* RenderImageResource::nullImage()
 {
     return Image::nullImage();
 }
 
 } // namespace WebCore