Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 20473002: Update RenderImage when the image src is cleared (Closed)

Created:
7 years, 5 months ago by spartha
Modified:
7 years, 4 months ago
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, gavinp+loader_chromium.org, jchaffraix+rendering, Nate Chapin
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Update RenderImage when the image src is cleared When the src is removed via JavaScript, the image loader now updates the renderer. BUG=123017 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155294

Patch Set 1 #

Total comments: 3

Patch Set 2 : Applied Review comments & rebaselined a test case #

Patch Set 3 : #

Total comments: 7

Patch Set 4 : #

Patch Set 5 : Test case is modified, and slight change, review needed #

Total comments: 3

Patch Set 6 : Re-baselined one of the expected test result #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -6 lines) Patch
M LayoutTests/canvas/philip/tests/2d.drawImage.image.incomplete.omitted-expected.txt View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/fast/images/image-change-src.html View 1 2 3 4 1 chunk +17 lines, -0 lines 0 comments Download
A LayoutTests/fast/images/image-change-src-expected.html View 1 2 3 4 1 chunk +10 lines, -0 lines 0 comments Download
M LayoutTests/virtual/gpu/canvas/philip/tests/2d.drawImage.image.incomplete.omitted-expected.txt View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/ImageLoader.cpp View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M Source/core/rendering/RenderImage.cpp View 1 2 3 4 3 chunks +3 lines, -3 lines 1 comment Download
M Source/core/rendering/RenderImageResource.cpp View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
spartha
Proposed patch.
7 years, 5 months ago (2013-07-25 20:37:25 UTC) #1
Nate Chapin
https://codereview.chromium.org/20473002/diff/1/Source/core/loader/ImageLoader.cpp File Source/core/loader/ImageLoader.cpp (right): https://codereview.chromium.org/20473002/diff/1/Source/core/loader/ImageLoader.cpp#newcode219 Source/core/loader/ImageLoader.cpp:219: if (m_image.get()) { Aren't m_image and newImage the same ...
7 years, 5 months ago (2013-07-25 21:00:31 UTC) #2
esprehn
https://codereview.chromium.org/20473002/diff/1/Source/core/rendering/RenderImageResource.cpp File Source/core/rendering/RenderImageResource.cpp (right): https://codereview.chromium.org/20473002/diff/1/Source/core/rendering/RenderImageResource.cpp#newcode77 Source/core/rendering/RenderImageResource.cpp:77: } else if (m_renderer->isImage() && m_renderer->isRenderImage()) { Checking isRenderImage() ...
7 years, 5 months ago (2013-07-26 03:18:17 UTC) #3
Nate Chapin
ImageLoader changes are fine.
7 years, 5 months ago (2013-07-26 18:59:02 UTC) #4
spartha
On 2013/07/26 18:59:02, Nate Chapin wrote: > ImageLoader changes are fine. How about the changes ...
7 years, 4 months ago (2013-07-27 04:41:33 UTC) #5
spartha
I have refactored the previous patch. imageChanged() is now called instead of triggering a layout ...
7 years, 4 months ago (2013-07-29 12:26:33 UTC) #6
esprehn
https://codereview.chromium.org/20473002/diff/26001/LayoutTests/canvas/philip/tests/2d.drawImage.image.incomplete.omitted-expected.txt File LayoutTests/canvas/philip/tests/2d.drawImage.image.incomplete.omitted-expected.txt (left): https://codereview.chromium.org/20473002/diff/26001/LayoutTests/canvas/philip/tests/2d.drawImage.image.incomplete.omitted-expected.txt#oldcode2 LayoutTests/canvas/philip/tests/2d.drawImage.image.incomplete.omitted-expected.txt:2: This test seems to fail now? You should talk ...
7 years, 4 months ago (2013-07-29 18:52:37 UTC) #7
spartha
https://codereview.chromium.org/20473002/diff/26001/LayoutTests/canvas/philip/tests/2d.drawImage.image.incomplete.omitted-expected.txt File LayoutTests/canvas/philip/tests/2d.drawImage.image.incomplete.omitted-expected.txt (left): https://codereview.chromium.org/20473002/diff/26001/LayoutTests/canvas/philip/tests/2d.drawImage.image.incomplete.omitted-expected.txt#oldcode2 LayoutTests/canvas/philip/tests/2d.drawImage.image.incomplete.omitted-expected.txt:2: On 2013/07/29 18:52:37, esprehn wrote: > This test seems ...
7 years, 4 months ago (2013-07-30 01:36:19 UTC) #8
esprehn
LGTM Yay for bug fixes!
7 years, 4 months ago (2013-07-30 01:39:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sudarshan.p@samsung.com/20473002/36001
7 years, 4 months ago (2013-07-30 01:57:58 UTC) #10
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=446
7 years, 4 months ago (2013-07-30 06:45:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sudarshan.p@samsung.com/20473002/36001
7 years, 4 months ago (2013-07-30 08:55:25 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sudarshan.p@samsung.com/20473002/36001
7 years, 4 months ago (2013-07-30 10:17:12 UTC) #13
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=491
7 years, 4 months ago (2013-07-30 12:44:09 UTC) #14
spartha
A new patch set has been uploaded. Needs a "LGTM" all over again! Sorry for ...
7 years, 4 months ago (2013-07-30 15:50:29 UTC) #15
spartha
The re-baselined expected txt result for one of the test cases was missing causing the ...
7 years, 4 months ago (2013-07-31 09:58:07 UTC) #16
eseidel
lgtm
7 years, 4 months ago (2013-08-01 01:24:28 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sudarshan.p@samsung.com/20473002/74001
7 years, 4 months ago (2013-08-01 01:25:40 UTC) #18
commit-bot: I haz the power
7 years, 4 months ago (2013-08-01 03:33:47 UTC) #19
Message was sent while issue was closed. 
Change committed as 155294

Powered by Google App Engine
This is Rietveld 408576698