third_party/WebKit/Source/core/animation/EffectInput.h - Issue 2047293002: Code cleanup: Replace Element with Document in element.animate()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/EffectInput.h

Issue 2047293002: Code cleanup: Replace Element with Document in element.animate() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_killForceConversionsToAnimatableValues

Patch Set: Fix unit test crash. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/AnimationInputHelpersTest.cpp ('k') | third_party/WebKit/Source/core/animation/EffectInput.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/EffectInput.h

diff --git a/third_party/WebKit/Source/core/animation/EffectInput.h b/third_party/WebKit/Source/core/animation/EffectInput.h

index 372aee53ac0df6f6e2f70812ae9ededd7c63bb17..f33afe2f2ddc16baf0f37bff21eebf514d4010ff 100644

--- a/third_party/WebKit/Source/core/animation/EffectInput.h

+++ b/third_party/WebKit/Source/core/animation/EffectInput.h

@@ -15,19 +15,18 @@ namespace blink {

class EffectModel;

class EffectModelOrDictionarySequenceOrDictionary;

class Dictionary;

-class Element;

+class Document;

class ExceptionState;

class ExecutionContext;

class CORE_EXPORT EffectInput {

STATIC_ONLY(EffectInput);

public:

- // TODO(alancutter): Replace Element* parameter with Document&.

- static EffectModel* convert(Element*, const EffectModelOrDictionarySequenceOrDictionary&, ExecutionContext*, ExceptionState&);

+ static EffectModel* convert(Document&, const EffectModelOrDictionarySequenceOrDictionary&, ExecutionContext*, ExceptionState&);

private:

- static EffectModel* convertArrayForm(Element&, const Vector<Dictionary>& keyframes, ExceptionState&);

- static EffectModel* convertObjectForm(Element&, const Dictionary& keyframe, ExceptionState&);

+ static EffectModel* convertArrayForm(Document&, const Vector<Dictionary>& keyframes, ExceptionState&);

+ static EffectModel* convertObjectForm(Document&, const Dictionary& keyframe, ExceptionState&);

};

} // namespace blink