third_party/WebKit/Source/core/animation/EffectInput.h - Issue 2047293002: Code cleanup: Replace Element with Document in element.animate()

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/animation/EffectInput.h

Issue 2047293002: Code cleanup: Replace Element with Document in element.animate() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_killForceConversionsToAnimatableValues

Patch Set: Fix unit test crash. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/AnimationInputHelpersTest.cpp ('k') | third_party/WebKit/Source/core/animation/EffectInput.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef EffectInput_h	5 #ifndef EffectInput_h

6 #define EffectInput_h	6 #define EffectInput_h

7	7

8 #include "core/CoreExport.h"	8 #include "core/CoreExport.h"

9 #include "core/animation/EffectModel.h"	9 #include "core/animation/EffectModel.h"

10 #include "wtf/Allocator.h"	10 #include "wtf/Allocator.h"

11 #include "wtf/Vector.h"	11 #include "wtf/Vector.h"

12	12

13 namespace blink {	13 namespace blink {

14	14

15 class EffectModel;	15 class EffectModel;

16 class EffectModelOrDictionarySequenceOrDictionary;	16 class EffectModelOrDictionarySequenceOrDictionary;

17 class Dictionary;	17 class Dictionary;

18 class Element;	18 class Document;

19 class ExceptionState;	19 class ExceptionState;

20 class ExecutionContext;	20 class ExecutionContext;

21	21

22 class CORE_EXPORT EffectInput {	22 class CORE_EXPORT EffectInput {

23 STATIC_ONLY(EffectInput);	23 STATIC_ONLY(EffectInput);

24 public:	24 public:

25 // TODO(alancutter): Replace Element* parameter with Document&.	25 static EffectModel* convert(Document&, const EffectModelOrDictionarySequence OrDictionary&, ExecutionContext*, ExceptionState&);

26 static EffectModel* convert(Element, const EffectModelOrDictionarySequenceO rDictionary&, ExecutionContext, ExceptionState&);

27	26

28 private:	27 private:

29 static EffectModel* convertArrayForm(Element&, const Vector<Dictionary>& key frames, ExceptionState&);	28 static EffectModel* convertArrayForm(Document&, const Vector<Dictionary>& ke yframes, ExceptionState&);

30 static EffectModel* convertObjectForm(Element&, const Dictionary& keyframe, ExceptionState&);	29 static EffectModel* convertObjectForm(Document&, const Dictionary& keyframe, ExceptionState&);

31 };	30 };

32	31

33 } // namespace blink	32 } // namespace blink

34	33

35 #endif	34 #endif

OLD	NEW