third_party/WebKit/Source/core/layout/LayoutBox.cpp - Issue 2047283002: Avoid touching z-index in StyleAdjuster by using an isStackingContext flag instead

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2047283002: Avoid touching z-index in StyleAdjuster by using an isStackingContext flag instead (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update old z-index stacking context test Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp ('K') | « third_party/WebKit/Source/core/dom/Element.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp » ('j') | third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

index 9137ecf1dc9429612d281307f6f2dbf45e1b35a7..996643f530660368f1f890b096a58fb8b90e312b 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

@@ -108,7 +108,7 @@ PaintLayerType LayoutBox::layerTypeRequired() const

// position:static elements that are not flex-items get their z-index coerced to auto.

if (isPositioned() || createsGroup() || hasClipPath() || hasTransformRelatedProperty()

|| style()->hasCompositorProxy() || hasHiddenBackface() || hasReflection() || style()->specifiesColumns()

- || !style()->hasAutoZIndex() || style()->shouldCompositeForCurrentAnimations())

+ || style()->isStackingContext() || style()->shouldCompositeForCurrentAnimations())

return NormalPaintLayer;

if (hasOverflowClip())

@@ -1388,7 +1388,7 @@ static bool isCandidateForOpaquenessTest(const LayoutBox& childBox)

if (childLayer->compositingState() != NotComposited)

return false;

// FIXME: Deal with z-index.

- if (!childStyle.hasAutoZIndex())

+ if (childStyle.isStackingContext())

return false;

if (childLayer->hasTransformRelatedProperty() || childLayer->isTransparent() || childLayer->hasFilterInducingProperty())

return false;