third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp - Issue 2047283002: Avoid touching z-index in StyleAdjuster by using an isStackingContext flag instead

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp

Issue 2047283002: Avoid touching z-index in StyleAdjuster by using an isStackingContext flag instead (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update old z-index stacking context test Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp ('K') | « third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp b/third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp

index 760c11e5a279ac2aa688dadf426a2688aaf08fcf..62809a6fca47b80556bb37ef8b5df837a45c26ed 100644

--- a/third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp

@@ -98,6 +98,7 @@ void LayoutFullScreen::updateStyle()

// Create a stacking context:

fullscreenStyle->setZIndex(INT_MAX);

+ fullscreenStyle->updateIsStackingContext(false, false);

rune 2016/06/09 09:10:25 Multiple bools like this hurts readability.

alancutter (OOO until 2018) 2016/06/10 04:59:30 Replaced with enums though it looks a bit ugly.

fullscreenStyle->setFontDescription(FontDescription());

fullscreenStyle->font().update(nullptr);