Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/permissions/permission_infobar_delegate.cc

Issue 2047253002: Add hooks to permission layer for permission action reporting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permission-reporter-implementation
Patch Set: fix nit: remove bracket Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/permissions/permission_bubble_request_impl.cc ('K') | « chrome/browser/permissions/permission_context_base.cc ('k') | chrome/browser/permissions/permission_uma_util.h » ('j') | chrome/browser/permissions/permission_uma_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/permissions/permission_infobar_delegate.cc
diff --git a/chrome/browser/permissions/permission_infobar_delegate.cc b/chrome/browser/permissions/permission_infobar_delegate.cc
index 14a9f5d58be081869d42a5920cff2a3c8e730f40..3a1b329a7a40c02a8b8847b15c2a4665dc73fe18 100644
--- a/chrome/browser/permissions/permission_infobar_delegate.cc
+++ b/chrome/browser/permissions/permission_infobar_delegate.cc
@@ -12,7 +12,9 @@
PermissionInfobarDelegate::~PermissionInfobarDelegate() {
if (!action_taken_)
- PermissionUmaUtil::PermissionIgnored(permission_type_, requesting_origin_);
+ // TODO(stefanocs): Pass in the non null profile.
raymes 2016/06/20 02:46:33 nit: the->a
stefanocs 2016/06/21 01:37:17 Done.
+ PermissionUmaUtil::PermissionIgnored(permission_type_, requesting_origin_,
+ nullptr);
}
PermissionInfobarDelegate::PermissionInfobarDelegate(
« chrome/browser/permissions/permission_bubble_request_impl.cc ('K') | « chrome/browser/permissions/permission_context_base.cc ('k') | chrome/browser/permissions/permission_uma_util.h » ('j') | chrome/browser/permissions/permission_uma_util.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698