Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1459)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/permissions/permission_bubble_request_impl.cc

Issue 2047253002: Add hooks to permission layer for permission action reporting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permission-reporter-implementation
Patch Set: fix nit: remove bracket Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/media/media_stream_devices_controller.cc ('k') | chrome/browser/permissions/permission_context_base.cc » ('j') | chrome/browser/permissions/permission_infobar_delegate.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/permissions/permission_bubble_request_impl.cc
diff --git a/chrome/browser/permissions/permission_bubble_request_impl.cc b/chrome/browser/permissions/permission_bubble_request_impl.cc
index 20017753f8c837f8a765390fe0888fbc495a50ee..a0290a5b4766e2e5b2d5c5b22a6e6c01244dbd89 100644
--- a/chrome/browser/permissions/permission_bubble_request_impl.cc
+++ b/chrome/browser/permissions/permission_bubble_request_impl.cc
@@ -29,7 +29,9 @@ PermissionBubbleRequestImpl::PermissionBubbleRequestImpl(
PermissionBubbleRequestImpl::~PermissionBubbleRequestImpl() {
DCHECK(is_finished_);
if (!action_taken_)
- PermissionUmaUtil::PermissionIgnored(permission_type_, request_origin_);
+ // TODO(stefanocs): Pass in the non null profile.
raymes 2016/06/20 02:46:33 nit: the->a
stefanocs 2016/06/21 01:37:17 Done.
+ PermissionUmaUtil::PermissionIgnored(permission_type_, request_origin_,
+ nullptr);
}
gfx::VectorIconId PermissionBubbleRequestImpl::GetVectorIconId() const {
« no previous file with comments | « chrome/browser/media/media_stream_devices_controller.cc ('k') | chrome/browser/permissions/permission_context_base.cc » ('j') | chrome/browser/permissions/permission_infobar_delegate.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698