xfa_fm2jscontext method cleanup - pt VII

xfa_fm2jscontext method cleanup - pt VII

This CL formats ::WordNum, ::Upper, ::Uuid, ::Substr, ::Stuff, ::Str, ::Space,
::RTrim, ::Right, ::Replace, ::Parse, ::Ltrim, ::Lower, ::Len, ::Left, ::Format,
::HTMLSTR2Code, ::HTMLCode2STR, ::EncodeXML, ::EncodeHTML, ::EncodeURL
and ::Encode.

Committed: https://pdfium.googlesource.com/pdfium/+/cf7f322173824e65747410b907724153ba14e19c

[dsinclair, 2016-06-08 15:51:09]

Patchset #1 (id:1) has been deleted

[dsinclair, 2016-06-08 15:51:33]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2016-06-08 15:51:34]

PTAL.

[Tom Sepez, 2016-06-08 17:24:08]

https://codereview.chromium.org/2047103004/diff/20001/xfa/fxfa/fm2js/xfa_fm2j...
File xfa/fxfa/fm2js/xfa_fm2jscontext.cpp (right):

https://codereview.chromium.org/2047103004/diff/20001/xfa/fxfa/fm2js/xfa_fm2j...
xfa/fxfa/fm2js/xfa_fm2jscontext.cpp:4049: wsPattern += FX_WSTRC(L"}");
nit: why not just 
  wsPattern = FX_WSTRC(L"date{") + wsPattern + FX_WSTRC(L"date{");

Also, WSTRC() serves no purpose IIRC since the default promotions apply so long
as there is already a widestring in all operations in the expression.

https://codereview.chromium.org/2047103004/diff/20001/xfa/fxfa/fm2js/xfa_fm2j...
xfa/fxfa/fm2js/xfa_fm2jscontext.cpp:4788: if (fNumber < 0 || fNumber >
922337203685477550) {
nit 0.0f and 922337203685477550.0f

[Tom Sepez, 2016-06-08 17:24:22]

LGTM otherwise.

[dsinclair, 2016-06-08 19:56:26]

PTAL. Cleaned up all the string appending I found in the file, please review the
diff to the last patchset.

https://codereview.chromium.org/2047103004/diff/20001/xfa/fxfa/fm2js/xfa_fm2j...
File xfa/fxfa/fm2js/xfa_fm2jscontext.cpp (right):

https://codereview.chromium.org/2047103004/diff/20001/xfa/fxfa/fm2js/xfa_fm2j...
xfa/fxfa/fm2js/xfa_fm2jscontext.cpp:4049: wsPattern += FX_WSTRC(L"}");
On 2016/06/08 17:24:07, Tom Sepez wrote:
> nit: why not just 
>   wsPattern = FX_WSTRC(L"date{") + wsPattern + FX_WSTRC(L"date{");
> 
> Also, WSTRC() serves no purpose IIRC since the default promotions apply so
long
> as there is already a widestring in all operations in the expression.

Done.

https://codereview.chromium.org/2047103004/diff/20001/xfa/fxfa/fm2js/xfa_fm2j...
xfa/fxfa/fm2js/xfa_fm2jscontext.cpp:4788: if (fNumber < 0 || fNumber >
922337203685477550) {
On 2016/06/08 17:24:08, Tom Sepez wrote:
> nit 0.0f and 922337203685477550.0f

Done.

[Tom Sepez, 2016-06-08 21:43:07]

lgtm++

[dsinclair, 2016-06-09 03:33:46]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-06-09 03:33:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2047103004/70001

[commit-bot: I haz the power, 2016-06-09 03:34:07]

Description was changed from

==========
xfa_fm2jscontext method cleanup - pt VII

This CL formats ::WordNum, ::Upper, ::Uuid, ::Substr, ::Stuff, ::Str, ::Space,
::RTrim, ::Right, ::Replace, ::Parse, ::Ltrim, ::Lower, ::Len, ::Left, ::Format,
::HTMLSTR2Code, ::HTMLCode2STR, ::EncodeXML, ::EncodeHTML, ::EncodeURL
and ::Encode.
==========

to

==========
xfa_fm2jscontext method cleanup - pt VII

This CL formats ::WordNum, ::Upper, ::Uuid, ::Substr, ::Stuff, ::Str, ::Space,
::RTrim, ::Right, ::Replace, ::Parse, ::Ltrim, ::Lower, ::Len, ::Left, ::Format,
::HTMLSTR2Code, ::HTMLCode2STR, ::EncodeXML, ::EncodeHTML, ::EncodeURL
and ::Encode.

Committed:
https://pdfium.googlesource.com/pdfium/+/cf7f322173824e65747410b907724153ba14...
==========

[commit-bot: I haz the power, 2016-06-09 03:34:08]

Committed patchset #4 (id:70001) as
https://pdfium.googlesource.com/pdfium/+/cf7f322173824e65747410b907724153ba14...