Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Issue 2046123004: xfa_fm2jscontext method cleanup - pt VIII (Closed)

Created:
4 years, 6 months ago by dsinclair
Modified:
4 years, 6 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

xfa_fm2jscontext method cleanup - pt VIII Cleanup ::logical_not_operator, ::negative_operator, ::positive_operator, ::divide_operator, ::multiple_operator, ::minus_operator, ::plus_operator, ::greaterequal_operator, ::greater_operator, ::lessequal_operator, ::less_operator, ::fm_ref_equal, ::notequality_operator, ::equality_operator, ::logical_and_operator, ::logical_or_operator, ::assign_value_operator, ::Put, ::Post, ::Get, ::TrillionUS and ::WordUS. Committed: https://pdfium.googlesource.com/pdfium/+/947c87348d30ec8065a646e6da09e863e8f24cfa

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+476 lines, -468 lines) Patch
M xfa/fxfa/fm2js/xfa_fm2jscontext.cpp View 7 chunks +476 lines, -468 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (4 generated)
dsinclair
PTAL.
4 years, 6 months ago (2016-06-08 21:08:41 UTC) #3
Tom Sepez
lgtm
4 years, 6 months ago (2016-06-08 21:16:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046123004/20001
4 years, 6 months ago (2016-06-09 03:40:18 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 03:40:38 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/947c87348d30ec8065a646e6da09e863e8f2...

Powered by Google App Engine
This is Rietveld 408576698