Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 204703002: Rename NOTIFICATION_EXTENSION_UNLOADED to (Closed)

Created:
6 years, 9 months ago by not at google - send to devlin
Modified:
6 years, 9 months ago
CC:
chromium-reviews, vandebo (ex-Chrome), sadrul, tzik, dcheng, markusheintz_, kinuko+watch, miu+watch_chromium.org, extensions-reviews_chromium.org, benjhayden+dwatch_chromium.org, dbeam+watch-options_chromium.org, kalyank, pedrosimonetti+watch_chromium.org, dbeam+watch-ntp_chromium.org, jennb, nhiroki, pam+watch_chromium.org, jianli, chromium-apps-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org, Lei Zhang, tfarina, Dmitry Titov, tommycli, robertshield, Greg Billock, estade+watch_chromium.org, James Su, ben+ash_chromium.org
Visibility:
Public.

Description

Rename NOTIFICATION_EXTENSION_UNLOADED to NOTIFICATION_EXTENSION_UNLOADED_DEPRECATED since ExtensionRegistry::AddObserver replaces it. BUG=354046 R=rockot@chromium.org TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258071

Patch Set 1 #

Patch Set 2 : maybe upload wont do something bizarre this time #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -174 lines) Patch
M apps/app_load_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M apps/app_window.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M apps/app_window_geometry_cache.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/shortcuts_backend.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/autocomplete/shortcuts_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_provider_observers.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/background/background_application_list_model.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/background/background_application_list_model.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/background/background_contents_service.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chrome_notification_types.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_internal_extension_provider.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/active_tab_permission_granter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/active_tab_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/bluetooth/bluetooth_event_router.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/bluetooth/bluetooth_event_router_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/debugger/debugger_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/declarative/rules_registry_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/idle/idle_api_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/idle/idle_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/operation_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/input_ime/input_ime_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/location/location_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/management/management_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries_private/gallery_watch_state_tracker.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/media_galleries_private/gallery_watch_state_tracker.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/omnibox/omnibox_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/power/power_api_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/power/power_api_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/push_messaging/push_messaging_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/spellcheck/spellcheck_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/streams_private/streams_private_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/system_indicator/system_indicator_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_action_manager.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_icon_image.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_infobar_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_keybinding_registry.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_notification_observer.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_toolbar_model.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_warning_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_web_ui_override_registrar.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/image_loader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/install_tracker.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/lazy_background_page_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/menu_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/menu_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/plugin_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/user_script_listener.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/user_script_master.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/managed_mode/managed_user_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/media_galleries/media_scan_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/media_scan_manager.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/notifications/notification_system_observer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/performance_monitor/performance_monitor.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/sync_file_system_service.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/themes/theme_service.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 2 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/ui/browser.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/extensions/extension_installed_bubble.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/panels/panel.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/panels/panel_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/app_list/start_page_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/extensions/command_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/app_launcher_handler.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/font_settings_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/policy_ui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/uber/uber_ui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/api/api_resource_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/event_router.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/lazy_background_task_queue.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/process_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/process_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
not at google - send to devlin
The only non-trivial part here is the comment I added to the notification in the ...
6 years, 9 months ago (2014-03-19 16:20:13 UTC) #1
Ken Rockot(use gerrit already)
lgtm
6 years, 9 months ago (2014-03-19 16:25:45 UTC) #2
not at google - send to devlin
The CQ bit was checked by kalman@chromium.org
6 years, 9 months ago (2014-03-19 16:33:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/204703002/20001
6 years, 9 months ago (2014-03-19 16:34:19 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 17:17:13 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=56169
6 years, 9 months ago (2014-03-19 17:17:14 UTC) #6
not at google - send to devlin
The CQ bit was checked by kalman@chromium.org
6 years, 9 months ago (2014-03-19 17:27:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/204703002/20001
6 years, 9 months ago (2014-03-19 17:28:57 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-19 20:24:11 UTC) #9
Message was sent while issue was closed. 
Change committed as 258071

Powered by Google App Engine
This is Rietveld 408576698