Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3449)

Unified Diff: chrome/browser/background/background_contents_service.cc

Issue 204703002: Rename NOTIFICATION_EXTENSION_UNLOADED to (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: maybe upload wont do something bizarre this time Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/background/background_contents_service.cc
diff --git a/chrome/browser/background/background_contents_service.cc b/chrome/browser/background/background_contents_service.cc
index 9ddf27e9b6522691d7a9f2ef020b78d788b1c473..b122cf60a5e18d452cc4855168465d297b06288d 100644
--- a/chrome/browser/background/background_contents_service.cc
+++ b/chrome/browser/background/background_contents_service.cc
@@ -173,7 +173,7 @@ void NotificationImageReady(
// Origin URL must be different from the crashed extension to avoid the
// conflict. NotificationSystemObserver will cancel all notifications from
- // the same origin when NOTIFICATION_EXTENSION_UNLOADED.
+ // the same origin when NOTIFICATION_EXTENSION_UNLOADED_DEPRECATED.
// TODO(mukai, dewittj): remove this and switch to message center
// notifications.
DesktopNotificationService::AddIconNotification(
@@ -339,7 +339,7 @@ void BackgroundContentsService::StartObserving(Profile* profile) {
// Listen for extensions to be unloaded so we can shutdown associated
// BackgroundContents.
- registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_UNLOADED,
+ registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_UNLOADED_DEPRECATED,
content::Source<Profile>(profile));
// Make sure the extension-crash balloons are removed when the extension is
@@ -456,7 +456,7 @@ void BackgroundContentsService::Observe(
}
break;
}
- case chrome::NOTIFICATION_EXTENSION_UNLOADED:
+ case chrome::NOTIFICATION_EXTENSION_UNLOADED_DEPRECATED:
switch (content::Details<UnloadedExtensionInfo>(details)->reason) {
case UnloadedExtensionInfo::REASON_DISABLE: // Fall through.
case UnloadedExtensionInfo::REASON_TERMINATE: // Fall through.
« no previous file with comments | « chrome/browser/background/background_application_list_model.cc ('k') | chrome/browser/chrome_notification_types.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698