Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Issue 2047013003: Revert of Add a buildflag to use the handle verifier in a per module mode. (Closed)

Created:
4 years, 6 months ago by battre
Modified:
4 years, 6 months ago
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add a buildflag to use the handle verifier in a per module mode. (patchset #9 id:180001 of https://codereview.chromium.org/1977833003/ ) Reason for revert: ScopedHandleTest.* tests fail to die on try bots. BUG=618205 Original issue's description: > Add a buildflag to use the handle verifier in a per module mode. > > The HandleVerifier prevent you from using any ScopedHandle during a module initialization (i.e. if a DLL use one in DllMain this will call back into its host executable that hasn't been initialized yet and things will derail). In this CL I'm adding a build flag to make it possible to use it in a single module mode.. > > Committed: https://crrev.com/a89708a5c1bfe778ed1615f0bc92f0e9ae2e2192 > Cr-Commit-Position: refs/heads/master@{#398361} TBR=wfh@chromium.org,chrisha@chromium.org,thakis@chromium.org,sebmarchand@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/71f86049e34c437a0a7498b231bb19353486f81f Cr-Commit-Position: refs/heads/master@{#398496}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -62 lines) Patch
M base/BUILD.gn View 2 chunks +1 line, -5 lines 0 comments Download
M base/base.gyp View 3 chunks +1 line, -23 lines 0 comments Download
D base/win/BUILD.gn View 1 chunk +0 lines, -23 lines 0 comments Download
M base/win/scoped_handle.cc View 2 chunks +1 line, -2 lines 0 comments Download
M base/win/scoped_handle_test_dll.cc View 2 chunks +1 line, -2 lines 0 comments Download
M build/common.gypi View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
battre
Created Revert of Add a buildflag to use the handle verifier in a per module ...
4 years, 6 months ago (2016-06-08 06:54:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2047013003/1
4 years, 6 months ago (2016-06-08 06:54:14 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 06:54:51 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 06:56:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/71f86049e34c437a0a7498b231bb19353486f81f
Cr-Commit-Position: refs/heads/master@{#398496}

Powered by Google App Engine
This is Rietveld 408576698