Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1945)

Unified Diff: base/base.gyp

Issue 2047013003: Revert of Add a buildflag to use the handle verifier in a per module mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/BUILD.gn ('k') | base/win/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/base.gyp
diff --git a/base/base.gyp b/base/base.gyp
index 39037a3c52b05eb90785435bd783893e9fb748ce..86d2331e8fb004b169b25b2913414df3400e0f94 100644
--- a/base/base.gyp
+++ b/base/base.gyp
@@ -24,7 +24,6 @@
'allocator/allocator.gyp:allocator',
'allocator/allocator.gyp:allocator_features#target',
'base_debugging_flags#target',
- 'base_win_features#target',
'base_static',
'base_build_date#target',
'../testing/gtest.gyp:gtest_prod',
@@ -1020,7 +1019,7 @@
},
{
# GN version: //base/debug:debugging_flags
- # Since this generates a file, it must only be referenced in the target
+ # Since this generates a file, it most only be referenced in the target
# toolchain or there will be multiple rules that generate the header.
# When referenced from a target that might be compiled in the host
# toolchain, always refer to 'base_debugging_flags#target'.
@@ -1032,27 +1031,6 @@
'ENABLE_PROFILING=<(profiling)',
],
},
- },
- {
- # GN version: //base/win:base_win_features
- # Since this generates a file, it must only be referenced in the target
- # toolchain or there will be multiple rules that generate the header.
- # When referenced from a target that might be compiled in the host
- # toolchain, always refer to 'base_win_features#target'.
- 'target_name': 'base_win_features',
- 'conditions': [
- ['OS=="win"', {
- 'includes': [ '../build/buildflag_header.gypi' ],
- 'variables': {
- 'buildflag_header_path': 'base/win/base_features.h',
- 'buildflag_flags': [
- 'SINGLE_MODULE_MODE_HANDLE_VERIFIER=<(single_module_mode_handle_verifier)',
- ],
- },
- }, {
- 'type': 'none',
- }],
- ],
},
{
'type': 'none',
« no previous file with comments | « base/BUILD.gn ('k') | base/win/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698