Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 2046953002: [heap] Unregister shrinked large object memory from chunk map. (Closed)

Created:
4 years, 6 months ago by Hannes Payer (out of office)
Modified:
4 years, 6 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Unregister shrinked large object memory from chunk map. BUG=chromium:617883 LOG=n Committed: https://crrev.com/2b38d3121b5fd0e409cdda0071fa2e0ec2846ab2 Cr-Commit-Position: refs/heads/master@{#36793}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -21 lines) Patch
M src/hashmap.h View 2 chunks +14 lines, -0 lines 0 comments Download
M src/heap/spaces.h View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M src/heap/spaces.cc View 1 2 3 4 5 4 chunks +31 lines, -21 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ulan
lgtm
4 years, 6 months ago (2016-06-07 14:27:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046953002/100001
4 years, 6 months ago (2016-06-07 14:29:18 UTC) #4
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 6 months ago (2016-06-07 15:03:15 UTC) #5
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/2b38d3121b5fd0e409cdda0071fa2e0ec2846ab2 Cr-Commit-Position: refs/heads/master@{#36793}
4 years, 6 months ago (2016-06-07 15:04:56 UTC) #7
Hannes Payer (out of office)
4 years, 6 months ago (2016-06-08 06:11:28 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/2046563008/ by hpayer@chromium.org.

The reason for reverting is: Revert because uncommit of lo is broken..

Powered by Google App Engine
This is Rietveld 408576698