Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2046793002: Move didMeaningfulLayout calls from WebViewClient to WebWidgetClient. (Closed)

Created:
4 years, 6 months ago by lfg
Modified:
4 years, 5 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dglazkov+blink, jam, kinuko+watch, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move didMeaningfulLayout calls from WebViewClient to WebWidgetClient. This is part of a refactor to split WebView/WebWidget. BUG=419087 Committed: https://crrev.com/b0f2e3de0153fff39641a65d9790939e7b705501 Cr-Commit-Position: refs/heads/master@{#404706}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : testwebwidgetclient #

Patch Set 4 : print #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -12 lines) Patch
M components/printing/renderer/print_web_view_helper.cc View 1 2 3 5 chunks +9 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 1 chunk +4 lines, -3 lines 2 comments Download
M third_party/WebKit/Source/web/tests/FrameTestHelpers.h View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebViewClient.h View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
lfg
PTAL.
4 years, 5 months ago (2016-07-06 16:00:13 UTC) #2
dcheng
lgtm https://codereview.chromium.org/2046793002/diff/60001/third_party/WebKit/Source/web/WebViewImpl.cpp File third_party/WebKit/Source/web/WebViewImpl.cpp (right): https://codereview.chromium.org/2046793002/diff/60001/third_party/WebKit/Source/web/WebViewImpl.cpp#newcode2029 third_party/WebKit/Source/web/WebViewImpl.cpp:2029: WebWidgetClient* client = WebLocalFrameImpl::fromFrame(frame)->frameWidget()->client(); Hmm, does this entire ...
4 years, 5 months ago (2016-07-07 01:54:57 UTC) #3
lfg
https://codereview.chromium.org/2046793002/diff/60001/third_party/WebKit/Source/web/WebViewImpl.cpp File third_party/WebKit/Source/web/WebViewImpl.cpp (right): https://codereview.chromium.org/2046793002/diff/60001/third_party/WebKit/Source/web/WebViewImpl.cpp#newcode2029 third_party/WebKit/Source/web/WebViewImpl.cpp:2029: WebWidgetClient* client = WebLocalFrameImpl::fromFrame(frame)->frameWidget()->client(); On 2016/07/07 01:54:56, dcheng wrote: ...
4 years, 5 months ago (2016-07-07 14:27:46 UTC) #4
lfg
jochen@chromium.org: Please review changes in components/, content/
4 years, 5 months ago (2016-07-07 14:28:06 UTC) #6
jochen (gone - plz use gerrit)
lgtm
4 years, 5 months ago (2016-07-08 13:00:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2046793002/60001
4 years, 5 months ago (2016-07-11 18:40:03 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-11 19:17:38 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-11 19:17:56 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 19:19:52 UTC) #16
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/b0f2e3de0153fff39641a65d9790939e7b705501
Cr-Commit-Position: refs/heads/master@{#404706}

Powered by Google App Engine
This is Rietveld 408576698