Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 2046793002: Move didMeaningfulLayout calls from WebViewClient to WebWidgetClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: print Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_view_impl.cc ('k') | third_party/WebKit/Source/web/tests/FrameTestHelpers.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebViewImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp
index 3e92e32a2f867341300bb60c550f5729a13a1c55..b50d6a16f70ec4f7cbb10637aa45ff60086b009f 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.cpp
+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp
@@ -2026,22 +2026,23 @@ void WebViewImpl::updateAllLifecyclePhases()
if (FrameView* view = mainFrameImpl()->frameView()) {
LocalFrame* frame = mainFrameImpl()->frame();
+ WebWidgetClient* client = WebLocalFrameImpl::fromFrame(frame)->frameWidget()->client();
dcheng 2016/07/07 01:54:56 Hmm, does this entire function need to move to Web
lfg 2016/07/07 14:27:46 Yes, but we'll also need to do some stuff in Frame
if (m_shouldDispatchFirstVisuallyNonEmptyLayout && view->isVisuallyNonEmpty()) {
m_shouldDispatchFirstVisuallyNonEmptyLayout = false;
// TODO(esprehn): Move users of this callback to something
// better, the heuristic for "visually non-empty" is bad.
- client()->didMeaningfulLayout(WebMeaningfulLayout::VisuallyNonEmpty);
+ client->didMeaningfulLayout(WebMeaningfulLayout::VisuallyNonEmpty);
}
if (m_shouldDispatchFirstLayoutAfterFinishedParsing && frame->document()->hasFinishedParsing()) {
m_shouldDispatchFirstLayoutAfterFinishedParsing = false;
- client()->didMeaningfulLayout(WebMeaningfulLayout::FinishedParsing);
+ client->didMeaningfulLayout(WebMeaningfulLayout::FinishedParsing);
}
if (m_shouldDispatchFirstLayoutAfterFinishedLoading && frame->document()->isLoadCompleted()) {
m_shouldDispatchFirstLayoutAfterFinishedLoading = false;
- client()->didMeaningfulLayout(WebMeaningfulLayout::FinishedLoading);
+ client->didMeaningfulLayout(WebMeaningfulLayout::FinishedLoading);
}
}
}
« no previous file with comments | « content/renderer/render_view_impl.cc ('k') | third_party/WebKit/Source/web/tests/FrameTestHelpers.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698