Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 204673007: Move didChangeSelection to WebFrameClient. (Closed)

Created:
6 years, 9 months ago by jam
Modified:
6 years, 9 months ago
Reviewers:
jamesr
CC:
blink-reviews, abarth-chromium, dglazkov+blink, gavinp+loader_chromium.org, Nate Chapin, groby+blinkspell_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Move didChangeSelection to WebFrameClient. BUG=304341 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169603

Patch Set 1 #

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -9 lines) Patch
M Source/core/editing/Editor.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/loader/EmptyClients.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/EditorClient.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/EditorClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/EditorClientImpl.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M public/web/WebFrameClient.h View 1 chunk +6 lines, -0 lines 0 comments Download
M public/web/WebViewClient.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
jam
6 years, 9 months ago (2014-03-19 22:06:00 UTC) #1
jamesr
lgtm
6 years, 9 months ago (2014-03-19 22:16:12 UTC) #2
jam
The CQ bit was checked by jam@chromium.org
6 years, 9 months ago (2014-03-19 22:58:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/204673007/20001
6 years, 9 months ago (2014-03-19 23:00:19 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 23:04:08 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 9 months ago (2014-03-19 23:04:09 UTC) #6
jam
The CQ bit was checked by jam@chromium.org
6 years, 9 months ago (2014-03-19 23:40:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/204673007/20001
6 years, 9 months ago (2014-03-19 23:40:57 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-20 03:47:27 UTC) #9
Message was sent while issue was closed. 
Change committed as 169603

Powered by Google App Engine
This is Rietveld 408576698