Source/web/EditorClientImpl.cpp - Issue 204673007: Move didChangeSelection to WebFrameClient.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/EditorClientImpl.cpp

Issue 204673007: Move didChangeSelection to WebFrameClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: update Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/EditorClientImpl.cpp

diff --git a/Source/web/EditorClientImpl.cpp b/Source/web/EditorClientImpl.cpp

index 8a441518ebe122f048958f76a3284bb1397d2dab..28dab1c28e94f9e6a08726f7dbed7a38fac40dbf 100644

--- a/Source/web/EditorClientImpl.cpp

+++ b/Source/web/EditorClientImpl.cpp

@@ -27,6 +27,7 @@

#include "config.h"

#include "EditorClientImpl.h"

+#include "WebFrameClient.h"

#include "WebFrameImpl.h"

#include "WebPermissionClient.h"

#include "WebViewClient.h"

@@ -46,10 +47,11 @@ EditorClientImpl::~EditorClientImpl()

{

}

-void EditorClientImpl::respondToChangedSelection(WebCore::SelectionType selectionType)

+void EditorClientImpl::respondToChangedSelection(LocalFrame* frame, WebCore::SelectionType selectionType)

{

- if (m_webView->client())

- m_webView->client()->didChangeSelection(selectionType != WebCore::RangeSelection);

+ WebFrameImpl* webFrame = WebFrameImpl::fromFrame(frame);

+ if (webFrame->client())

+ webFrame->client()->didChangeSelection(selectionType != WebCore::RangeSelection);

}

void EditorClientImpl::respondToChangedContents()

« no previous file with comments | « Source/web/EditorClientImpl.h ('k') | public/web/WebFrameClient.h » ('j') | no next file with comments »