Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 2046713003: fix pathops fuzz bugs (Closed)

Created:
4 years, 6 months ago by caryclark
Modified:
4 years, 6 months ago
Reviewers:
rmistry, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fix pathops fuzz bugs Fail out in a couple of new places when the input data is very large and exceeds the limits of the pathops machinery. Most of the change here plumbs in a way to exclude an assert in one of these exceptional cases. The current SkAddIntersection implementation and the inner functions it calls has no way to report an error to the root caller for an early exit, so rather than add that in, exclude the assert when the test that would trigger it runs (allowing the test to otherwise ensure that it properly fails). TBR=reed@google.com BUG=617586, 617635 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2046713003 Committed: https://skia.googlesource.com/skia/+/dae6b97705fde08958b1a36fa6ce685d28fc692c

Patch Set 1 #

Patch Set 2 : forgot test file #

Patch Set 3 : once again forgot test file #

Patch Set 4 : remove pathops_unittests specific debugging #

Patch Set 5 : fix fuzz bugs #

Patch Set 6 : fix most vexing parse #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -29 lines) Patch
M src/pathops/SkAddIntersections.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkDConicLineIntersection.cpp View 1 2 3 4 1 chunk +8 lines, -3 lines 0 comments Download
M src/pathops/SkIntersections.h View 1 2 3 4 3 chunks +7 lines, -1 line 0 comments Download
M src/pathops/SkOpBuilder.cpp View 1 2 3 4 5 chunks +13 lines, -6 lines 0 comments Download
M src/pathops/SkOpCoincidence.cpp View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M src/pathops/SkPathOpsCommon.h View 1 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download
M src/pathops/SkPathOpsCommon.cpp View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M src/pathops/SkPathOpsOp.cpp View 1 2 3 4 2 chunks +4 lines, -3 lines 0 comments Download
M src/pathops/SkPathOpsSimplify.cpp View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M src/pathops/SkPathOpsTightBounds.cpp View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M src/pathops/SkPathOpsTypes.h View 1 2 3 4 3 chunks +3 lines, -0 lines 0 comments Download
M src/pathops/SkPathOpsTypes.cpp View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M tests/PathOpsAngleIdeas.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M tests/PathOpsAngleTest.cpp View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M tests/PathOpsBuilderTest.cpp View 1 2 3 4 1 chunk +22 lines, -0 lines 0 comments Download
M tests/PathOpsExtendedTest.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M tests/PathOpsExtendedTest.cpp View 1 2 3 4 2 chunks +13 lines, -6 lines 0 comments Download
M tests/PathOpsOpTest.cpp View 1 2 3 4 1 chunk +50 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046713003/100001
4 years, 6 months ago (2016-06-07 20:31:50 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-07 21:22:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046713003/100001
4 years, 6 months ago (2016-06-08 11:27:22 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 11:28:24 UTC) #12
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/dae6b97705fde08958b1a36fa6ce685d28fc692c

Powered by Google App Engine
This is Rietveld 408576698