src/pathops/SkOpCoincidence.cpp - Issue 2046713003: fix pathops fuzz bugs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/pathops/SkOpCoincidence.cpp

Issue 2046713003: fix pathops fuzz bugs (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: fix most vexing parse Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/pathops/SkOpCoincidence.cpp

diff --git a/src/pathops/SkOpCoincidence.cpp b/src/pathops/SkOpCoincidence.cpp

index 130d1daff777eb392cf6183223b3035eeecc1ea3..42ee5c6091198b4c1eab57c4a2df45d3c419b815 100755

--- a/src/pathops/SkOpCoincidence.cpp

+++ b/src/pathops/SkOpCoincidence.cpp

@@ -90,6 +90,9 @@ bool SkOpCoincidence::addExpanded(SkChunkAlloc* allocator

}

SkOpSpanBase* test = start->upCast()->next();

SkOpSpanBase* oTest = coin->fFlipped ? oStart->prev() : oStart->upCast()->next();

+ if (!oTest) {

+ return false;

+ }

while (test != end || oTest != oEnd) {

if (!test->ptT()->contains(oTest->ptT())) {

// use t ranges to guess which one is missing

« no previous file with comments | « src/pathops/SkOpBuilder.cpp ('k') | src/pathops/SkPathOpsCommon.h » ('j') | no next file with comments »